vladris / tinkerer

Python blogging engine
https://vladris.com/tinkerer
Other
305 stars 81 forks source link

Embedded videos break tinkerer #87

Open pop opened 9 years ago

pop commented 9 years ago

When I embed an iframe video (youtube, vimeo, etc) I get a strange bug where my entire website will build just fine until it gets to the video and no content after the video will be built. Is this a known issue?

Info:

(tinkerSite)$ tinker --version
Tinkerer version 1.5
(tinkerSite)$ python --version
Python 3.4.2
(tinkerSite)$ pip freeze
You are using pip version 6.0.6, however version 6.0.8 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Babel==1.3
cssselect==0.9.1
docutils==0.12
httplib2==0.9
Jinja2==2.7.3
lxml==3.4.1
MarkupSafe==0.23
Pygments==2.0.1
pyquery==1.2.9
pytz==2014.10
Sphinx==1.2.3
Tinkerer==1.5

Code:

Title
=====                                                

Content                                                                        

.. raw:: html                                                                      

    <iframe width="560" height="315" src="https://www.youtube-nocookie.com/embed/ybJ5DiHT0NM" frameborder="0" allowfullscreen></iframe>

More content <-- This does not load at all, nor do any following posts

I have talked with a friend of mine and they do not get the error. I may have a weird config but I don't suspect that should cause problems since I'm mostly using the defaults.

If I'm doing something wrong we should update the documentation because I can't find anything to answer my question.

martin-ueding commented 9 years ago

I do have the same problem. Somehow the raw html contents get mangled.

So in the document I have the following:

<iframe width="640" height="480" src="https://www.youtube.com/embed/xx" frameborder="0" allowfullscreen></iframe>

This appears in the output of the blog post itself just fine. However, on the index of the blog (i.e. if I put that video before .. more::), it will become the following:

<iframe width="640" height="480" src="https://www.youtube.com/embed/xx" frameborder="0" allowfullscreen=""/>

Firefox is then not able to cope with the HTML and does not display anything beyond that. For me the fix is to have no videos before .. more::, but that is a bit sad as I would like to show the video up front.