search

vladyslav-burylov / resharper-testlinker2

Easy navigation between test and production code.
MIT License
6 stars 4 forks source link

Added Action Attribute Because It Makes The Plugin Work #14

Closed YarinOmesi closed 1 year ago

YarinOmesi commented 1 year ago

I have seen this issue #9, that mentions that the plugin is working in version 2022.2 but not in 2022.2.1. I found a commit the is removing the Action attribute from GotoLinkedTypes2Action, Commit : https://github.com/vladyslav-burylov/resharper-testlinker2/commit/4823f270ef0feb793781029e24675bdfbc8b7cdf

You mentioned in the commit that the Action attribute is deprecated, but the constructor is the one that is deprecated. The Attribute is seems the be needed that the action will work.

EdvardasDlugauskas commented 1 year ago

Just want to point out that the shortcut has been recently changed to ALT + F7, see #8.

I also imagine the value has to come from a config instead of being hardcoded. Since the user can change the keybinding at any time.

@vladyslav-burylov could you take a look at this PR? I don't think I have effort to spare testing different solutions with different plugin versions, but if this fix is merged then it'll be easy for me to upgrade the plugin version and test it out. Related issue: #9

mu88 commented 1 year ago

Thanks for your contribution, @YarinOmesi , I really appreciate 👍🏻

As @EdvardasDlugauskas already pointed out, the shortcut has been changed to Alt + F7. And your commit would reintroduce the build warning CS0612: image

EdvardasDlugauskas commented 1 year ago

You mentioned in the commit that the Action attribute is deprecated, but the constructor is the one that is deprecated. The Attribute is seems the be needed that the action will work.

I see the issue is closed. So what was the conclusion? Does the plugin work for everyone else?

mu88 commented 1 year ago

It was @YarinOmesi who closed the PR - maybe he can give us more information :)

As mentioned here, I'm still waiting for further feedback since it works on the two machines that I have access to.