[Android Bootcamp] Project 3: Simple Twitter Client - Ready for Review

[vlaljani]

Hi,

My app is complete. Please review. /cc @codepathreview @codepath

Thanks much!

Best, Vibha

[codepathreview]

:+1: Excellent work again. Great to see you put in the effort to turn in a polished assignment.. A few notes after checking out the code:

• Good to see you were able to format the timestamp cleanly (consider externalizing to utils class)
• Nice to see you used the SwipeRefreshLayout for easy timeline refreshes
• Good to see you refreshed the timeline after composing a new tweet
• Great job implementing the compose tweet feature as a dialog (Consider combining ComposeDialog and ReplyDialog to reuse code.)
• Good to see you added ActiveAndroid annotations to the models for offline usage
• Nice touch with the character count being displayed while the user composes a tweet and disabling the tweet button if the count exceeds 140 chars.
• Consider activating functionality like retweet and favorite using the respective endpoints.

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

[vlaljani]

Thank you! :) Yes the plan was to combine and re-use the 2 dialogs but because it was already close to submission time by the time I had them working (and I didn't want to break requirements) I couldn't! I'll combine them in time for this week's homework :)

A question I had was on ClassLoaders (I have never used those) but it seems like if we want to parcel a User inside a Tweet Or an arraylist we need to use those ? (So instead of passing two separate Parcelables in the intent, I would've been able to just send one) - or is that not recommended?