search

vlandham / bubble_chart_v4

d3v4 implementation of bubble charts.
Other
60 stars 70 forks source link

fix link to d3.v4.min.js #4

Closed stanleykylee closed 6 years ago

vlandham commented 7 years ago

Thanks for the PR @stanleykylee . Is the current link broken for you? If so - what browser are you using?

I believe the double-slash prefix is the common solution when a site can be hosted from either http or https

More details are in the first answer of: https://stackoverflow.com/questions/9646407/two-forward-slashes-in-a-url-src-href-attribute

With even the slightest possibility of a mixed http/https environment, just use the double slash/protocol relative URLs for loading your resources — assuming that the host serving the content is both http and https enabled.

But if this doesn't work in a particular environment - it would be great to know!

stanleykylee commented 7 years ago

Yeah it was broken for me. I didn't know that the double slash was supposed to work? I'm only running on a local file with Firefox browser to do some testing. Possibly because it isn't hosted it couldn't translate it properly?

On July 25, 2017 at 10:11:06 AM, Jim Vallandingham (notifications@github.com(mailto:notifications@github.com)) wrote:

Thanks for the PR @stanleykylee(https://github.com/stanleykylee) . Is the current link broken for you? If so - what browser are you using?

I believe the double-slash prefix is the common solution when a site can be hosted from either http or https

More details are in the first answer of: https://stackoverflow.com/questions/9646407/two-forward-slashes-in-a-url-src-href-attribute

With even the slightest possibility of a mixed http/https environment, just use the double slash/protocol relative URLs for loading your resources — assuming that the host serving the content is both http and https enabled.

But if this doesn't work in a particular environment - it would be great to know!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub(https://github.com/vlandham/bubble_chart_v4/pull/4#issuecomment-317804089), or mute the thread(https://github.com/notifications/unsubscribe-auth/AE6C7JvGhfCp_h8rYwPq0JcYQDh5VN65ks5sRiGqgaJpZM4Oh60v).

vlandham commented 7 years ago

Ah. perhaps it might be because you are just loading the page directly instead of hosting it on a local webserver?

stanleykylee commented 7 years ago

Yes, that is exactly what I am doing for my current dev poc work. Haven't put it on a server yet. You may ignore the PR if you'd like as I presume most people will develop on a hosted platform?

On July 25, 2017 at 2:43:07 PM, Jim Vallandingham (notifications@github.com(mailto:notifications@github.com)) wrote:

Ah. perhaps it might be because you are just loading the page directly instead of hosting it on a local webserver?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub(https://github.com/vlandham/bubble_chart_v4/pull/4#issuecomment-317881505), or mute the thread(https://github.com/notifications/unsubscribe-auth/AE6C7KK_R9W1exvjdbZIP1PLLn41Wegaks5sRmFqgaJpZM4Oh60v).

vlandham commented 7 years ago

Ahha. ok then. I believe most people will probably be using a webserver with d3 - there are other issues with loading the html file straight in the browser, as noted on https://github.com/d3/d3/wiki :

Browsers enforce strict security permissions to prevent you from reading files out of the local file system. To develop locally, you must run a local web server rather than using file://

i think i will keep the // and hopefully everything will work for you when you start using a local or remote server.

Thanks for the discussion though!