vlang / gitly

Light and fast GitHub/GitLab alternative written in V
GNU General Public License v3.0
1.37k stars 72 forks source link

Feature request for supporting per-language icons #133

Open aminnairi opened 3 years ago

aminnairi commented 3 years ago

Something a la GitLab that could be cool to have a quick grasp at the file types in a repository folder.

ghost commented 1 year ago

Hi aminnairi.

I don't know if it's a good idea, I was thinking about using shields to demonstrate icons on gitly

aminnairi commented 1 year ago

If you can provide a visual example I think it would help getting the idea behind using shields for people that don't know what it is or what it looks like if this sounds good to you.

ghost commented 1 year ago

Hi aminnairi, thank you for feedback.

what this shields?

Concise, consistent, and legible badges in SVG and raster format

but... what this Shields.io?

Quality metadata badges for open source projects

JalonSolov commented 1 year ago

Those are badges, not icons for individual files.

aminnairi commented 1 year ago

Unfortunately, these badges are more suited for open-source projects that wants to show something important like a package that has 0 vulnerabilities, or the link for an NPM package etc...

I was thinking something even simpler like SVG versions of the most popular file extensions so that it remains easy to customize in color, size, etc...

ghost commented 1 year ago

Hi JalonSolov.

Those are badges, not icons for individual files.

shields is a good project, and can be used in the frontend interface for icons you request.

JalonSolov commented 1 year ago

The page literally says "This is home to Shields.io, a service for concise, consistent, and legible badges in SVG and raster format". A badge is not a file icon.

Badges are meant for things like showing what percentage of a project is V vs C vs ..., or for showing that the project meets some criteria.

They are not meant for showing a V icon on a .v file.

ghost commented 1 year ago

Hi JalonSolov.

The page literally says "This is home to Shields.io, a service for concise, consistent, and legible badges in SVG and raster format". A badge is not a file icon. Badges are meant for things like showing what percentage of a project is V vs C vs ..., or for showing that the project meets some criteria. They are not meant for showing a V icon on a .v file.

This is usually done in the frontend interface, a good example of this is GitHub. Or... a complementary idea would be to have a css icon library or use unicode - these are complementary ideas to create file icons.

1. concept

image

image-description: As we can see in the image, we have a list of icons that appear. Note: This image is illustrative and I took it from github/khang-nd/spc

2. question/feedback

What do you think of this idea?

JalonSolov commented 1 year ago

Unicode doesn't have the V icon, markdown icon, etc. gitly just needs small icon files in whatever format makes the most sense.