search

vlang / ui

A cross-platform UI library written in V
MIT License
2.31k stars 154 forks source link

refactor: rename vars and params to prevent module name shadowing #525

Closed ttytm closed 1 year ago

ttytm commented 1 year ago

This PR renames variables and parameters to prevent module name shadowing. Related to: https://github.com/vlang/v/pull/18118

I mostly opted for gui. On master current handlings to not shadow the ui module are gui and u. Please let me know what you prefer, some quick changes are no work.

https://github.com/vlang/ui/blob/417db89c2b771601c88404399cc144a01e8716e8/src/ui.v#L66

https://github.com/vlang/ui/blob/417db89c2b771601c88404399cc144a01e8716e8/src/tool_text_style.v#L128

medvednikov commented 1 year ago

Thanks!

I think u is better than gui in receivers.

ttytm commented 1 year ago

@medvednikov

if there is nothing blocking we can make the related PR on vlang/v ready for a potential merge with the changes here and the PR on vinix.

medvednikov commented 1 year ago

@tobealive sorry for the delay, merged.

we can make the related PR on vlang/v ready for a potential merge with the changes here and the PR on vinix.

Yes :)

ttytm commented 12 months ago

No worries, thank you @medvednikov

I've checked the rest of the CI tested modules. We should be able to finish it off with this one: https://github.com/vlang/vinix/pull/122