fix(treesitter): always free token contents to prevent a memory leak

vlang / vls

V language server. (Old V language server - see v-analyzer)

MIT License

314 stars 53 forks source link

fix(treesitter): always free token contents to prevent a memory leak #446

Closed amaanq closed 1 year ago

amaanq commented 1 year ago

Detected with libfuzzer

Also just inlined the stack so there's no need to allocate twice for the stack and its data ptr

medvednikov commented 1 year ago

hey

thanks!

VLS is in the middle of a HUGE re-write, the repo is private atm, but it will be released in July:

https://github.com/v-analyzer

this re-write works great, vlang/vls is currently archived

amaanq commented 1 year ago

thanks for the response! Since this is archived, should I submit the changes to v-tree-sitter then? (Projects like nvim-treesitter use this to provide V syntax highlighting support, I can switch the repo to be v-tree-sitter if that's better)

medvednikov commented 1 year ago

I guess, yeah :)

i582 commented 1 year ago

thanks for the response! Since this is archived, should I submit the changes to v-tree-sitter then? (Projects like nvim-treesitter use this to provide V syntax highlighting support, I can switch the repo to be v-tree-sitter if that's better)

Hi When we release a new version, it will be cool if your changes are pushed there, I will check if I have already fixed them in the current version, since I rewrote the scanner

i582 commented 1 year ago

seems to be fixed in my version