Closed portrik closed 10 months ago
Woow, that's great!
@nedpals @danieldaeschle can you have a look at this please?
Why changed indentation to 8? Please undo that.
I am sorry about the indentation. It was not intentional and I did not notice it at all. It should be back in order now.
@danieldaeschle Are you still open for this PR? if all the review comment have been resolved?
If yes, I would like to continue the work.
if @tehSIRius does not respond, I can create a new branch based on his branch and then a new PR. (Your current review will be lost in the new PR and you need to review the new PR again)
Currently I'm not into this code but I'm sure there will be someone approving it
Currently I'm not into this code but I'm sure there will be someone approving it
This PR aims to update the current dependencies of the project to their latest versions. The changes to dependencies are as follows:
Additionally, I have fixed the issues being brought up by the
lint
script. The codebase is obviously outdated and I would love to bring up-to-speed with modern standards of VS Code. But I am limiting this PR to just include the least amount of changes to make eslint happy.The changes should not have any deep effects on logic. I can't be 100% sure as there are no tests. I suspect a lot of the code is broken, at least from my usage of the extension. However, I have checked the
lint
,testgrammar
,compile
andwatch
scripts and all passed without any issues.