search

vlang / vscode-vlang

V Language extension for Visual Studio Code.
MIT License
386 stars 52 forks source link

[DEPS] Update Dependencies #497

Closed portrik closed 10 months ago

portrik commented 1 year ago

This PR aims to update the current dependencies of the project to their latest versions. The changes to dependencies are as follows:

 @types/node                            12  →        18
 @types/vscode                      1.40.0  →    1.73.1
 @typescript-eslint/eslint-plugin    ^4.33  →     ^5.45
 @typescript-eslint/parser           ^4.33  →     ^5.45
 esbuild                           ^0.15.7  →  ^0.15.16
 eslint                              ^7.32  →     ^8.28
 markdownlint-cli                  ^0.31.1  →   ^0.32.2
 typescript                         ^4.6.4  →    ^4.9.3
 vsce                               ^2.7.0  →   ^2.14.0
 vscode-languageclient              ^7.0.0  →    ^8.0.2
 vscode-tmgrammar-test             ~0.0.11  →    ~0.1.1

Additionally, I have fixed the issues being brought up by the lint script. The codebase is obviously outdated and I would love to bring up-to-speed with modern standards of VS Code. But I am limiting this PR to just include the least amount of changes to make eslint happy.

The changes should not have any deep effects on logic. I can't be 100% sure as there are no tests. I suspect a lot of the code is broken, at least from my usage of the extension. However, I have checked the lint, testgrammar, compile and watch scripts and all passed without any issues.

zbyju commented 1 year ago

Woow, that's great!

medvednikov commented 1 year ago

@nedpals @danieldaeschle can you have a look at this please?

danieldaeschle commented 1 year ago

Why changed indentation to 8? Please undo that.

portrik commented 1 year ago

I am sorry about the indentation. It was not intentional and I did not notice it at all. It should be back in order now.

felixf4xu commented 1 year ago

@danieldaeschle Are you still open for this PR? if all the review comment have been resolved?

If yes, I would like to continue the work.

if @tehSIRius does not respond, I can create a new branch based on his branch and then a new PR. (Your current review will be lost in the new PR and you need to review the new PR again)

danieldaeschle commented 1 year ago

Currently I'm not into this code but I'm sure there will be someone approving it

danieldaeschle commented 1 year ago

Currently I'm not into this code but I'm sure there will be someone approving it