vlang / vscode-vlang

V Language extension for Visual Studio Code.
MIT License
385 stars 51 forks source link

`.vscodeignore` file should not ignore the whole `node_modules` folder #532

Closed felixf4xu closed 1 year ago

felixf4xu commented 1 year ago

Hi,

I'm testing a locally built/packaged vsix file for this repo but I got "Cannot find module 'vscode-languageclient'" when the package is loaded/reloaded by vscode.

vscode-languageclient should be packaged into the vsix file as show below (referenced from some other issue):

image

I debugged into this issue really hard and found that the whole folder of node_modules is ignored by .vscodeignore file. https://github.com/vlang/vscode-vlang/blob/441f50fad696175cb11e3ec74a5938c8b122c090/.vscodeignore#L3 The released v0.1.14 package does not have the same issue. But in theory, the .vscodeignore file should not ignore the whole node_modules folder.

Again, this issue is reported from a local build, so it's just for anyone who is re-packaging the extension locally and has the error of 'vscode-languageclient'.