Closed ttytm closed 11 months ago
The changes primarily focus on platform-specific adjustments for macOS, particularly in floating-point comparisons and LAPACK library usage. The CI/CD pipeline is simplified, and test execution steps are streamlined. The codebase now incorporates LAPACK functionality for macOS, and the test assertions have been updated to use tolerance checks for floating-point comparisons.
File(s) | Summary |
---|---|
.github/workflows/ci.yml |
Simplified the CI/CD pipeline by removing specific test configurations and adding the --skip-examples flag to test execution commands. |
float/float64/ge_test.v , iter/ranges_test.v , la/matrix_ops_test.v |
Introduced platform-specific tolerance checks for floating-point comparisons in tests. Enhanced assertions with failure messages displaying actual, expected values, and tolerance. |
vlas/cflags_d_cblas.v , vlas/cflags_notd_cblas.v |
Added header files and flags for LAPACK and CBLAS functionality on macOS. |
vlas/lapack_common.v , vlas/lapack_default.c.v , vlas/lapack_macos.c.v |
Removed unused functions, updated function signatures, and incorporated LAPACK functionality. |
vlas/conversions.v |
Simplified code by replacing if-else statements with conditional expressions and changing return types. |
🐇 "In the land of code, where logic is the road, Changes come and go, like a river's flow. Tolerance in tests, for platforms at their best, With LAPACK's zest, we're on a quest. Simplified CI/CD, as easy as one, two, three, Celebrate, for we are free! 🎉"
Best #182 first, then C types can be updated here as well before a merge.
Apparently math works different on mac, needed to add a little tolarance for some tests.
Summary by CodeRabbit