vlang / vsl

V library to develop Artificial Intelligence and High-Performance Scientific Computations
https://vlang.github.io/vsl
MIT License
340 stars 46 forks source link

noise: perlin2d fix + 3d implementation #193

Closed PottierLoic closed 6 months ago

PottierLoic commented 6 months ago

Fixed 2d perlin noise and added 3d function too !

using this code, the 2d perlin noise look like this:

for i in 0..pwidth {
  for j in 0..pheight {
    value := noise.perlin2d(i*0.1, j*0.1) * 255
    state.pixels[i][j] = u32(gx.rgb(u8(value), u8(value), u8(value)).abgr8())
  }
}

image

and using this code and by increasing depth we have this 3d perlin noise:

mut d := 0.01
for {
  for i in 0..pwidth {
    for j in 0..pheight {
      value := noise.perlin3d(i*0.02, j*0.02, d) * 255
      state.pixels[i][j] = u32(gx.rgb(u8(value), u8(value), u8(value)).abgr8())
    }
  }
  d += 0.02
  time.sleep(33 * time.millisecond)
}

perlin3d

Summary by CodeRabbit

coderabbitai[bot] commented 6 months ago

Walkthrough

The noise module has been expanded with new capabilities for generating Perlin noise, a popular gradient noise function. It now includes methods for both 2D and 3D noise generation. The update introduces a Perlin struct for 2D noise with methods to randomize and generate noise values, and a new function to calculate 3D Perlin noise.

Changes

File(s) Change Summary
noise/perlin2d.v Added Perlin struct with methods for 2D noise.
noise/perlin3d.v Introduced function for 3D Perlin noise.

Poem

🐰 "In the realm of code, so spry and bold,
A rabbit hopped through the fields of old.
With Perlin whispers in 2D and 3D, quite fair,
It crafted worlds with a random, soft flair." 🌌

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - You can directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging `@coderabbitai` in a comment. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - You can tag `@coderabbitai` in a PR comment and ask questions about the PR and the codebase. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.` - `@coderabbitai read the files in the src/scheduler package and generate README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
PottierLoic commented 6 months ago

Just realized that I didn't make it random, actually the permutation set never change... We can't just shuffle for every value because it wouldn't make perlin noise anymore so maybe creating a generator struct that hold the permutations is possible ? This way we can have a perlin.randomize() and a perlin.3d(x, y, z) etc.

larpon commented 6 months ago

Also run v fmt on the files

PottierLoic commented 6 months ago

completely forgot sorry

larpon commented 6 months ago

@ulises-jeremias I'm unsure what the linter errors are about 🤔

PottierLoic commented 6 months ago

I think it's good like this, I can add some examples later if needed.