Closed Eliyaan closed 5 months ago
The recent updates to the la/blas.v
file address critical issues in matrix and vector multiplication functions, focusing on the accuracy of array dimensions and strides. These adjustments ensure that operations like dgemv
and dger
now correctly handle large matrices without leading to dimension errors, directly targeting the problems outlined in the linked GitHub issue.
File | Change Summary |
---|---|
la/blas.v |
Adjusted parameters for dgemv and dger functions, specifically array dimensions and strides. |
Objective | Addressed | Explanation |
---|---|---|
Bug with matrix multiplication dimensions (#197) | ✅ | |
Matrix multiplications should work without errors (#197) | ✅ | |
Error with the leading dimension of matrix A in dgemv (#197) |
✅ | |
Suggested checks in dgemv might be incorrect (#197) |
✅ |
🐰 Code hops through fields of code, Fixing bugs where they showed. With every line, and every tweak, Ensures the math no longer bleak.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@Eliyaan I think this PR is not correct. Are your matrices row major? will test it later
I just fixed it on master along some other fixes!
Fix #197 (I'm not sure that this PR is correct but it fixes the issue)
Summary by CodeRabbit