search

vlastavesely / raleigh-reloaded

Raleigh Reloaded is a conservative GTK-3.20 theme aiming to revive the Raleigh theme, the default theme of GTK-2.0.
GNU General Public License v2.0
59 stars 9 forks source link

HiDPI Support #16

Closed dimkr closed 1 year ago

dimkr commented 2 years ago

Hi @vlastavesely!

This wonderful theme is the base the Puppy Linux GTK+ 3 themes (https://github.com/puppylinux-woof-CE?q=gtk3_) inherit from and I'm currently working on HiDPI support in Puppy (https://github.com/puppylinux-woof-CE/woof-CE/issues/3335, among others).

This theme contains many GTK+ 2 era, low-resolution assets that don't work well with scale factor 2. For example, the checkboxes:

185744196-b95fbcdc-6104-405a-bdac-c487574d7d62

To make this theme future-proof, they need to be replaced with CSS borders+box shadows (for example, the menu and toolbar borders, or the checkbox background+border) or SVG assets (for example, the V inside the checkbox). I'm working on this and hope to achieve 1:1 visual consistency.

vlastavesely commented 2 years ago

Hello, if I remember correctly, I tried checkboxes based on CSS borders but there were some problems and so I used PNG images. I will check the changes in your code and try to either use something or at least remember where the problem was.

dimkr commented 2 years ago

Made some good progress, most of the theme is pixel-perfect with scale factor 2. I doubled the size of all images, so they're rendered at size 100% with scaling factor 2, or size 50% with scaling factor 1.

I still see some blurry border images in notebook tabs :(

tab1 tab3

vlastavesely commented 2 years ago

Which desktop environment do you use? MATE, which I use, does not seem to have the scaling option.

dimkr commented 2 years ago

Which desktop environment do you use? MATE, which I use, does not seem to have the scaling option.

I don't use a desktop environment. I use dwl (a Wayland compositor) and set the scaling factor to 2 using wlr-randr --output whatever --scale 2.

vlastavesely commented 2 years ago

I played with it a bit. It is an interesting solution to double the size of the images. However this will not solve anything when the scaling is different from 200%. Also, I am not fully comfortable with it as it is a very specific thing that I have not seen in any other theme. I tried to make a SVG version but with little-to-no success. I am going to leave this issue opened and we will see whether to use your solution or leave it as it is.

I am not ruling out the possibility of me playing with it a bit in the following months but it is not going to be a priority for me :)

vlastavesely commented 1 year ago

I am closing the issue for now since I do not plan to work at this feature. But thanks for the effort.