search

vlc-rpc / vlc-discord-rpc

Display what you're watching on VLC media player as your Discord status with this Node.js application.
MIT License
34 stars 6 forks source link

Package "inflight" is deprecated & leaks memory #33

Open ynot01 opened 3 months ago

ynot01 commented 3 months ago

From npm: npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.

Lauren1066 commented 2 months ago

Thank you for bringing this up! I have determined mocha requires glob, which uses inflight. From the mocha repository: https://github.com/mochajs/mocha/issues/5148

If they update it, we will as well. For now, it seems to be out of my hands.

However, I did move chai to the developer dependencies, since it is only used for testing. https://github.com/vlc-rpc/vlc-discord-rpc/commit/bed3ae09da25dbe4d52a90c4ba9df3689af3dea9

Lauren1066 commented 2 months ago

I've also just pushed an update to the docs on the setup page. It now tells people to use --production when using npm to install. This means the developer dependencies should not install. So, there should be no issues for regular users any longer.