vle-forge / irritator

Other
5 stars 4 forks source link

model: filter logic added for threshold #70

Closed ovese closed 2 years ago

ovese commented 3 years ago

I have created this PR for further work on the filter atomic model

quesnel commented 3 years ago

Can you add a new unit test to check the filter model? Use a constant model to send a value to the filter model for example.

ovese commented 3 years ago

It's not sufficient. The model will do nothing here. It must receive data from the input port x[0] (transition function), affect the sigma to 0 (force to call lambda function) and send the filtered information. See the adder or mult model for QSS1 as example.

You need to write a transition function.

yes I am aware it is not complete. I am working on it already. Thank you

ovese commented 3 years ago

I have a clean build for the filter model to work. I just want to explore how to do the unit test with a constant block as requested

ovese commented 3 years ago

I rebased my commits to clean up the commit history as I had two commits pushed that had compile time issues

ovese commented 3 years ago

I have a challenge for the irritator-0.1.exe executable file. It is refactored to irritator-0.1.ilk (incremental linker file). meaning I can't launch it like previously to view the simulator

ovese commented 3 years ago

I have a challenge for the irritator-0.1.exe executable file. It is refactored to irritator-0.1.ilk (incremental linker file). meaning I can't launch it like previously to view the simulator

This is no more an issue after recompiling

ovese commented 3 years ago

All checks are passed

quesnel commented 3 years ago

Can you merge these three commits? In commit message, please add a space after ':' -> model:filter... becomes model: filter....

ovese commented 3 years ago

I have merged the commits and successfully rebased the featureFilter branch commits as requested

ovese commented 2 years ago

I have rebased the featureFilter branch commits

quesnel commented 2 years ago

Thank you. It's better to read!

quesnel commented 2 years ago

I have merged the commit. Thank you.

ovese commented 2 years ago

you are welcome