vlead / feedback-portal

This is the portal, where all kinds of feedback related to a lab or an experiment is filled in.
Other
0 stars 11 forks source link

Code review comments on 2nd Feb on college cloud post processing #39

Open ksripathi opened 7 years ago

ksripathi commented 7 years ago

Review comments on college cloud documentation :

1) Issue to be created on how flask wsgi issue got resolved with college registration form 2) Requirements to be modified as follows

3) Design section should be fixed

4) Post process of college cloud requirements

5) Post process script should be explained more like a story where & how it data will flow before put it into elastic search database

6) In docs 'up' links are broken 7) Generic function to check college details needs to be written 8) Link documentation b/w feedback and college cloud since all post processing apis are implemented as part of feedback service this gives lot of confusion so better explain more wherever required as needed. (Done)

ksripathi commented 7 years ago

9) Write separate module for dumping historic feedback data to elastic search database and set a cronjob for other module which will take regular feedback dump on every mid night. (Done) 10) Attach more explanation with implementation as design (Done)

ksripathi commented 7 years ago

Incorporated review comments