Code Review

[madhavipuliraju]

Minutes of the meeting (28th July 2016) Agenda: Code Review. Attendess: Thirumal, Sripathi, Madhavi

Following changes need to be done to the current model.

• Currently system implementation is repeated twice for testing the object and persistance. Need to be used only once.
• Test cases for object system and persistence system need to be implemented separately.
• When are two entities equal, this equality method for each entity needs to be implemented.
• All operations in the system are implemented with no knowledge of either the system uses pure objects or persistence objects.
• Need to add to_client() (wherever required) for better readability.
• Need to verify the implementation is satisfying data model or not and make necessary changes if required.
• Check all the imports and remove other imports if not used. Import only the required files.

[priya100raman]

Could you please elaborate on as to which section/milestone/release this review was done for and add link to the issues that track the changes suggested.

Also, if this review is specific to a milestone , please add this issue to the milestone so that all reviews/decisions made for a particular milestone gets captured in one issue which is part of that milestone.