vlead / outreach-portal-3.0

The new outreach portal built froma specification
Other
0 stars 0 forks source link

Implementation of System Operations #41

Open ksripathi opened 8 years ago

ksripathi commented 8 years ago

System holds all the operations which are invoked by the System interface. System checks all the State, Authorization, Arity and Type checks and then performs the action.

madhavipuliraju commented 8 years ago

Code review has done on following operations 1) Add User https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system.org#adduser Test Cases https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system-with-persistence.org#test-adduser 2) Add Institute https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system.org#addinstitute Test Cases https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system-with-persistence.org#test-add_institute 3) Add OC https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system.org#add_oc Test Cases https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system-with-persistence.org#test-add_oc 4) Add NC https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system.org#add_nc Test Cases https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system-with-persistence.org#test-addnc

Reference to the review comments at https://github.com/vlead/outreach-portal-3.0/issues/42

ksripathi commented 7 years ago

Code review needs to be done for the following operations

5) Add Role https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system.org#addrole Test Cases 6) Login https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system.org#login Test Cases 7) Logout https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system.org#logout Test Cases 8) Create Workshop https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system.org#create_workshop Test Cases 9) Conduct Workshop https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system.org#conduct_workshop Test Cases 10) Cancel Workshop https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system.org#cancel_workshop Test Cases 11) Upload Artifact https://github.com/vlead/outreach-portal-3.0/blob/madhavi/src/runtime/system/system.org#upload_artefact Test Cases