vlebourl / custom_vesync

Custom VeSync component for Home Assistant
97 stars 66 forks source link

Improve diagnostics #43

Closed vlebourl closed 2 years ago

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.74%.

Quality metrics Before After Change
Complexity 4.89 ⭐ 4.55 ⭐ -0.34 👍
Method Length 42.67 ⭐ 49.00 ⭐ 6.33 👎
Working memory 5.78 ⭐ 6.27 🙂 0.49 👎
Quality 79.06% 78.32% -0.74% 👎
Other metrics Before After Change
Lines 27 29 2
Changed files Quality Before Quality After Quality Change
custom_components/vesync/diagnostics.py 79.06% ⭐ 78.32% ⭐ -0.74% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication