Open blackvvine opened 2 years ago
I noticed that when running the train command, the "added data" CSV file classification_tools/data/training_data_added.csv is not actually appended to the "original" training dataset:
classification_tools/data/training_data_added.csv
https://github.com/vlegoy/rcATT/blob/f82f7fd456279abefcd3e0b50e8056345c11aeb7/classification_tools/__init__.py#L70
Note that the Pandas DataFrame.append function returns a new DataFrame and does not modify its input, so the corrected version would be:
DataFrame.append
train_data_df = train_data_df.append(train_data_added, ignore_index = True)
I'd be happy to submit this as a merge request, if that'd work.
I noticed that when running the train command, the "added data" CSV file
classification_tools/data/training_data_added.csv
is not actually appended to the "original" training dataset:https://github.com/vlegoy/rcATT/blob/f82f7fd456279abefcd3e0b50e8056345c11aeb7/classification_tools/__init__.py#L70
Note that the Pandas
DataFrame.append
function returns a new DataFrame and does not modify its input, so the corrected version would be:I'd be happy to submit this as a merge request, if that'd work.