vlggms / lobotomy-corp13

GNU Affero General Public License v3.0
28 stars 149 forks source link

QoH depression can happen during a work #1240

Open TaculoTaculo opened 11 months ago

TaculoTaculo commented 11 months ago

Round ID: irrelevant

Testmerges: irrelevant

Reproduction:

Pick QoH Before a meltdown that would trigger her depressed state from not having enough deaths happen in the facilty. issue work on her trigger a meltdown, most of the cases by someone else working on another abnormality QoH will enter depressed state mid work, having most of the PE generated be from her normal work sucess rates (unsure if going depressed mid work changes her work chance mid work too) On work end, if you get a good result, she will recover from depression, bypassing her whole depressed state mechanic.

civilCornball commented 10 months ago

This is a basegame bug, funnily enough. It's vitally important there when you don't have Execution bullets.

Do we still need this bug?

InsightfulParasite commented 1 month ago

Will be difficult to test but ill try and see if this is still a issue.

InsightfulParasite commented 1 month ago

I had to force it by calling the OnQliphothEvent proc on her.

https://github.com/vlggms/lobotomy-corp13/assets/109536843/e902b822-e765-4b21-8d39-2e67997b039e

InsightfulParasite commented 1 month ago

A way to fix this is to make her remember what state she was before work and check that when recovering after work. Ill have to talk to the other maintainers if this is actually a issue to fix though.