vlggms / lobotomy-corp13

GNU Affero General Public License v3.0
31 stars 155 forks source link

Removes Attack Speed Variable = 1 Runtime[DONE] #2273

Closed InsightfulParasite closed 1 month ago

InsightfulParasite commented 2 months ago

About The Pull Request

A runtime is occuring in line 110 of _ego_weapon.dm due to the inclusion of a unused attack_speed var.

Also changes default attack_speed from null to 1

The purpose of this crash message was because attack speed = 1 was redundant and attack speed = 0 defaulted to 1 anyways. However making this crash message or altering the resto f the code to remove 1 would be difficult since alot of attack_speed buffs and alterations are made on the assumption that the weapon has attack_speed = 1. Maybe in the future ill replace the attack speed alterations with a proc that defaults 0 to 1 but that would be alot.

The reason that so many shields have their attack_speed overrided is because the default attack speed of the shield subtype is 3.

Changelog

:cl:

tweak: _ego_weapon.dm fix: _ego_weapon.dm

/:cl: