search

vlgi / uai-components

Apache License 2.0
2 stars 1 forks source link

Input Icon Button Aria label fix #227

Closed 01oseluiz closed 9 months ago

01oseluiz commented 9 months ago

In GitLab by @ismaelpamplona on Jan 18, 2023, 13:46

STORYBOOK ALERT button - Critical Element does not have inner text that is visible to screen readers -Serious aria-label attribute does not exist or is empty

01oseluiz commented 9 months ago

In GitLab by @DaniloRaposo on Jan 27, 2023, 11:31

requested review from @DaniloRaposo

01oseluiz commented 9 months ago

In GitLab by @DaniloRaposo on Jan 27, 2023, 11:38

Commented on src/components/formFields/Input/Input.svelte line 271

O valor do icon é o nome que o ícone tem na lista de ícones, e muitas vezes esse nome não vai ser autoexplicativo em relação ao que o botão deve fazer. 

        <button class="icon icon-cursor" aria-label=`${icon} labeled button` on:click>
01oseluiz commented 9 months ago

In GitLab by @DaniloRaposo on Jan 27, 2023, 11:46

removed review request for @DaniloRaposo