search

vlingo-net / xoom-net-actors

Type safe Actor Model toolkit for reactive concurrency and resiliency using C# and other .NET languages.
Mozilla Public License 2.0
39 stars 18 forks source link

Align naming with Java version #50

Closed tjaskula closed 5 years ago

tjaskula commented 5 years ago

Just a small fix to naming World.StartWithDefault which lacks "s" compared to Java version. Now it has the correct name World.StartWithDefaults.

Noe need to release the new version

tjaskula commented 5 years ago

just lacking s at the end

tjaskula commented 5 years ago

Please @zpbappi, be very kind to this enormous PR :)

zpbappi commented 5 years ago

@tjaskula it's a massive "spot the difference" challenge. any way we can improve the diff? by the way, I think I have used the public method in some places. the usages need to be updated as well.

tjaskula commented 5 years ago

@zpbappi Yes, normally I would just push to master without PR such an insignificant change but well, I'm going through the PR's :) I'll update the public visibility to restrict it if needed. No problem.

VaughnVernon commented 5 years ago

@tjaskula He and I saw the same thing. It look like every line changed. Can you avoid the reformatting and change only one or a few lines?

tjaskula commented 5 years ago

@VaughnVernon I didn't do any reformatting. Just saw that Github presents like everything has changed but this is an eternal problem on this project that has strange file encodings resulting form using different editors. Sorry for that. If you use "Hide white spaces settings" you'll see the line that has changed.

VaughnVernon commented 5 years ago

@tjaskula Thanks for sharing with me Hide whitespace changes. I didn't know about that. Very handy!