search

vlingo-net / xoom-net-actors

Type safe Actor Model toolkit for reactive concurrency and resiliency using C# and other .NET languages.
Mozilla Public License 2.0
39 stars 18 forks source link

proxy generator enhancemets #53 #73

Closed mihaj closed 4 years ago

mihaj commented 4 years ago

I've run two additional tests and found the issue with the GetSimpleTypeName, I wrapped all the calls with new function TypeFullNameToString that replaces the + with . so the generated code is correct. I tried to call the TypeFullNameToString from the GetSimpleTypeName, but it's return is used to convert string to type so other tests failed. #53

mihaj commented 4 years ago

Even if the case is weird, the issue is that proxy generator did not handle that properly. In this particular case, the Type.FullName returned a type name, but instead of a . it used a + which was then written to the generated proxy code. This new method now converts this + to . so the generated proxy compiles.

mihaj commented 4 years ago

Can you please check the latest commit, It's about #25. I pushed the code before this PR is closed.. It's supposed to be in the next PR.

tjaskula commented 4 years ago

However the goal is not to delete it. It's unfinished and the goal of #25 is to do implementation.

mihaj commented 4 years ago

I've checked the JAVA version and they are now more compatible than in previous version. So nothing is removed atm.

tjaskula commented 4 years ago

Could yo post the link to the source ? It's easier to track what are you referring too

mihaj commented 4 years ago

Slf4jLogger.java Slf4jLoggerPlugin.java