vlingo / xoom-actors

The VLINGO XOOM platform SDK for the type-safe Actor Model, delivering Reactive concurrency, high scalability, high-throughput, and resiliency using Java and other JVM languages.
https://vlingo.io
Mozilla Public License 2.0
229 stars 28 forks source link

Make proxy generation logs configurable #33

Closed sharmapankaj2512 closed 5 years ago

sharmapankaj2512 commented 5 years ago

As of now the start up proxy generation messages (vlingo/actors: Generating proxy for) are logged using println statements, this restricts clients of the library from configuring them.

VaughnVernon commented 5 years ago

@sharmapankaj2512 Thanks for reporting! I have committed and pushed a fix for this that will be part of 0.8.0 in a few days. For now you can build from master and test it. I leave it up to you to close when you are confident that it's good.

sharmapankaj2512 commented 5 years ago

@VaughnVernon Thanks for the quick resolution. I will soon verify and close the issue.

VaughnVernon commented 5 years ago

@VaughnVernon Thanks for the quick resolution. I will soon verify and close the issue.

Hi @sharmapankaj2512 Could you please confirm the fix and close?

sharmapankaj2512 commented 5 years ago

@VaughnVernon how do I go about configuring the logging? Do I need to use vlingo-actors.properties?

VaughnVernon commented 5 years ago

@sharmapankaj2512 There are a few options.

If you use properties file configuration, look here: https://github.com/vlingo/vlingo-actors/blob/d553b60b74b443e2c2ca41f4fd4bb4119e99fba5/src/test/resources/vlingo-actors.properties#L36

And read this, too, for properties file configuration (just below the above link): https://github.com/vlingo/vlingo-actors/blob/d553b60b74b443e2c2ca41f4fd4bb4119e99fba5/src/test/resources/vlingo-actors.properties#L44

For fluent, in source code configuration, see this test for an example: https://github.com/vlingo/vlingo-actors/blob/master/src/test/java/io/vlingo/actors/ConfigurationTest.java

I hope this helps.

sharmapankaj2512 commented 5 years ago

@VaughnVernon Fixed. Verified master build using fluent configuration.

JDKLoggerPlugin.JDKLoggerPluginConfiguration
                .define()
                .defaultLogger()
                .name("vlingo")
                .handlerClass(DefaultHandler::class.java)
                .handlerName("vlingo")
                .handlerLevel("OFF")
VaughnVernon commented 5 years ago

@sharmapankaj2512 Thanks for reporting the issue and for confirming the fix!