Eliminate Bare TestUntil Uses

vlingo / xoom-actors

The VLINGO XOOM platform SDK for the type-safe Actor Model, delivering Reactive concurrency, high scalability, high-throughput, and resiliency using Java and other JVM languages.

https://vlingo.io

Mozilla Public License 2.0

229 stars 28 forks source link

Eliminate Bare TestUntil Uses #44

Closed VaughnVernon closed 5 years ago

VaughnVernon commented 5 years ago

The following tests must be converted to use AccessSafely rather than bare TestUntil:

ActorLifecycleTest
ActorsTest (abstract base for other tests)
BroadcastRouterTest
CharactersTest
CompletesActorProtocolTest
ContentBasedRouterTest
DeadLettersTest
LocalMessageTest
MockCompletes
SchedulerTest
StageTest
WorldDefaultConfigurationTest
WorldTest

VaughnVernon commented 5 years ago

See PR https://github.com/vlingo/vlingo-actors/pull/46

I will start a new Issue for these.

The test classes, that I have left with TestUntil, are :

ManyToOneConcurrentArrayQueueDispatcherTest RingBufferDispatcherTest RingBufferMailboxActorTest

The solutions using AccessSafely looked right on paper, but the test would hang indefinitely waiting to complete.

I am sure that with more time and better investigation it could be done.