Exceptions should never be suppressed

[alanStrait]

In using vlingo for application development the default actor supervisor policy seems to cause exceptions to be lost without being logged. While the documentation is clear that actor lifecycle methods should be overridden to understand why an actor has been stopped, it would be valuable for the default policy to, “log and stop” rather than just “stop.”

[VaughnVernon]

@alanStrait Thanks, this is good. Do you mean like this?

  protected void beforeRestart(final Throwable reason) {
    // override
    logger().log("Default recovery after: " + reason.getMessage(), reason);
    lifeCycle.afterStop(this);
  }

[alanStrait]

Yes, that would be helpful, it not a full stack trace (when in development mode).

[VaughnVernon]

@alanStrait Ok, will do. I think that all of the default supervisors log, but I may be wrong. If you can identify any supervisors missing logging I can fix those, too.

[VaughnVernon]

@alanStrait The Actor default recovery methods now implementing logging. Please test and close if you agree that it's fixed. (Again if you find other places that are missing essential logging please create and issue.)

[alanStrait]

Yes, that would be helpful, if not a full stack trace (for development mode).

Alan Strait | m.+1.720.840.8567

On Apr 26, 2019, at 12:52 PM, Vaughn Vernon notifications@github.com wrote:

@alanStrait https://github.com/alanStrait Thanks, this is good. Do you mean like this?

protected void beforeRestart(final Throwable reason) { // override logger().log("Default recovery after: " + reason.getMessage(), reason); lifeCycle.afterStop(this); } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vlingo/vlingo-actors/issues/45#issuecomment-487164003, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJ2FYN5NI6QNHRZRTRQL23PSNFOPANCNFSM4HIZQTFA.

[VaughnVernon]

@alanStrait The full stacktrace should log/print with the standard logging. If you agree, please Close this issue. See:

https://github.com/vlingo/vlingo-actors/blob/e6926cdf0a12978b40a7c4ffa103eb720732f599/src/main/java/io/vlingo/actors/plugin/logging/jdk/JDKLogger.java#L72

[alanStrait]

After picking up the change I reverted some source code to expose an NPE that I would have hoped to be logged. Unfortunately the behavior remains as before, no indication of what is wrong but also does not complete restful call. I'd suggest closing this and perhaps I'll be able to collect more information that may be helpful as time goes on.

[VaughnVernon]

Implemented. There may be other issues with recovery that are app/service specific. Closing.