search

vlingo / xoom-schemata

The VLINGO XOOM Schema Registry.
https://vlingo.io
Mozilla Public License 2.0
17 stars 9 forks source link

Revisit all FIXME's and TODO's inside code #161

Open Florian-Schoenherr opened 4 years ago

Florian-Schoenherr commented 4 years ago

Coming from #160, we need to find out what parts of the code still really need to be fixed/done. Main priority is what was mentioned in the issue: what was this line, where null was collector before supposed to do?

And while I'm at it, I would like to also fix the other TODO/FIXME's around the code. Maybe pointing to new issues. But I'm not certain which parts of it are still relevant. I hope that people who already worked on some of the non-ui code can help me out. As far as I know, @pflueras did ES-CQRS, so you will probably know a lot about the code base. If anyone else would know more about certain TODO/FIXME's, please @ them here.

Florian-Schoenherr commented 4 years ago

CodeResource.queryContextWith, is probably just old and not needed? There is a ContextData inside CodeResource.Collector, maybe it was to be used for that.

VaughnVernon commented 4 years ago

@Florian-Schoenherr These kinds of issues will all go into a separate backlog if they have merit. We can determine the actual needs later.

Florian-Schoenherr commented 4 years ago

@VaughnVernon for now, I hope someone knows about the "CodeResource context"-thing, at least. All the other stuff can go on the backlog.