search

vlingo / xoom-schemata

The VLINGO XOOM Schema Registry.
https://vlingo.io
Mozilla Public License 2.0
17 stars 9 forks source link

Descriptions aren't GET #168

Closed abdullahcalisir12 closed 3 years ago

abdullahcalisir12 commented 3 years ago

Descriptions are required to create organization, unit, etc, After creating one, Then when I refresh the page descriptions are empty.

VaughnVernon commented 3 years ago

@abdullahcalisir12 Which of the following are you using?

  1. GET /api/organizations
  2. GET /api/organizations/{organizationId}

The description is not provided with 1, but should be with 2.

Florian-Schoenherr commented 3 years ago

It is not provided. I seriously forgot. There is another one, I think categories on schema. It's a small change, someone just needs to add it to all the ...View.java classes.

Florian-Schoenherr commented 3 years ago

I'm truly sorry. Please use this as reference: https://github.com/vlingo/vlingo-schemata/commit/a74ae4f24cc8812331cc7de3d20c5fca5f4aca13 (it should be enough to have description on the respective ..Defined and ..Redefined merges and ..Views)

VaughnVernon commented 3 years ago

@Florian-Schoenherr Do you mean to tell us that you are human? 😃 No worries. Thanks for helping.

Florian-Schoenherr commented 3 years ago

Fixed by https://github.com/vlingo/vlingo-schemata/commit/3401469435b70e5632add1d199c98582b1415720