search

vlingo / xoom-schemata

The VLINGO XOOM Schema Registry.
https://vlingo.io
Mozilla Public License 2.0
17 stars 9 forks source link

[Compiler] Implement the TypeResolver interface in SchemaVersionQueriesActor to resolve types #89

Closed kmruiz closed 4 years ago

kmruiz commented 5 years ago

Right now the io.vlingo.schemata.query.SchemaVersionQueriesActor#resolve method is not fully implemented because it doesn't resolve correctly a type based on it's full qualified name.

We need to create a new query that will find the IDs:

based on their names, so the type can be resolved in the TBL_SCHEMAVERSIONS table.

wwerner commented 4 years ago

@pflueras This issue is closed by #94 and #95, correct?

pflueras commented 4 years ago

Unfortunately not. Running exploratory testing hangs when hitting this line: https://github.com/vlingo/vlingo-schemata/blob/c7b7bbab3f5c810df61be8fdf3109b25a866bee9/src/test/resources/rest-api-calls.http#L260

@VaughnVernon modified ResultReturns but that change didn't fix this issue. SQL query which selects appropriate SchemaVersion works fine (https://github.com/vlingo/vlingo-schemata/pull/94 and https://github.com/vlingo/vlingo-schemata/pull/95) but the pipeline hangs on the way of sending the response.

I am trying to fix the pipeline.

pflueras commented 4 years ago

This issue is likely to be fixed fixed by https://github.com/vlingo/vlingo-schemata/pull/117