Open jakzal opened 3 years ago
I stumbled upon this issue while upgrading from vlingo 1.3.0 to 1.4.0.
Since https://github.com/vlingo/vlingo-symbio-jdbc/pull/43, the Journal factory no longer works:
Journal.using(stage, JDBCJournalActor.class, dispatcher, configuration);
The implementation assumes that dispatcher is part of argument list:
static <A extends Actor, T, RS extends State<?>> Journal<T> using(final Stage stage, final Class<A> implementor, final Dispatcher<Dispatchable<Entry<T>,RS>> dispatcher, final Object...additional) { return additional.length == 0 ? stage.actorFor(Journal.class, implementor, dispatcher) : stage.actorFor(Journal.class, implementor, dispatcher, additional); }
While it is still valid for some implementations (like InMemoryJournalActor) it is no longer the case for JDBCJournalActor.
InMemoryJournalActor
JDBCJournalActor
/cc @pflueras
I stumbled upon this issue while upgrading from vlingo 1.3.0 to 1.4.0.
Since https://github.com/vlingo/vlingo-symbio-jdbc/pull/43, the Journal factory no longer works:
The implementation assumes that dispatcher is part of argument list:
While it is still valid for some implementations (like
InMemoryJournalActor
) it is no longer the case forJDBCJournalActor
./cc @pflueras