search

vlingo / xoom-wire

The VLINGO XOOM platform SDK wire protocol messaging implementations, such as with full-duplex TCP and UDP multicast, and RSocket, using VLINGO XOOM ACTORS.
Mozilla Public License 2.0
13 stars 11 forks source link

Eliminate catch throwable #18

Closed buritos closed 4 years ago

buritos commented 4 years ago

Replaces catch(Throwable) with catch(Exception) so that the application will not ignore Error.

VaughnVernon commented 4 years ago

I know it was already merged, but I have some concerns

Sorry, Alex! I didn't see that you were in the review. There are two schools of thought on catching Exception and Throwable. Will Errors be thrown?

alexguzun commented 4 years ago

No worries. We can't guarantee that underlying RSocket implementation will only throw checked exceptions. I think we should be defensive.