DateRangePicker

[james-criscuolo]

So I know this doesn't have daterangepicker capabilities yet, but if/when that occurs, here are some features I used in the old one:

• passing in a daterange to be chosen initially, or at any time during the use of the picker (say, someone adjusts the date from an external input).

• have multiple calendars, and those calendars are separate, meaning moving through months on one does not affect the other's month. The old implementation also did not allow the left calendar to pass the right calendar going forward, and vice-versa.

• Being able to select the start or end date on either calendar, potentially both on the same one. First click is start date, then a click after that date would be the end date, but a click before that date would move the start date further back.

I believe everything I described is how the ob-daterangepicker used to work. I can see how the new one is already set up pretty well to deal with dateranges, but if there is any way I can help with this please let me know.

[vlio20]

@james-criscuolo, I will definitely would like to add a dateragepicker to this lib. Two things have to made first:

1. E2E tests cover has to be increased (there is a project for that).
2. Refactoring to the current components to structures and modularity.

Hope to have the above in the week or 2, then will start working on the daterangepicker. When I will get to it I will create a project for it and then it would be supper cool to have some help.

[james-criscuolo]

Another small thing I didn't mention, and may even be considered a 'bug' for just the day-picker. If I set a max date and have multiple calendars (2 in my case), the right most calendar should show the latest available date. Currently, with max set to today (April 11), the 2nd calendar shows May. I guess this can be considered an opinion more than a bug, but having something settable for this is probably good. There's a similar case if you were to set min date, but I believe the current functionality would cover that, I guess its just something to be aware of if/when new logic is added to account for the max case.

[james-criscuolo]

Sorry should have mentioned this in the above post, but this is the last one I've found. The ob-daterangepicker used to show calendar days with single digits as just the digit, not 0 and then the digit (so '1' for the first instead of '01'). If the current functionality is still desired, I think a dayFormatter would be fitting here, or maybe just a boolean, as I'm not sure how much more variability there can be.

[mustafapsd]

Hi @vlio20 ! Is there any work for this? If there is not, I want to work for this.

[vlio20]

Nope. Go ahead @mustafapsd. I suggest that you will write here what features you plan to have + general design + ux/ui

[mustafapsd]

Hi @vlio20 . I've started to work on this feature. I'm a bit confused, especially in demo project :S Can you take a look at my last commits? Am I doing the right thing? Thank you for your answer!

Repo

Video

[vlio20]

@mustafapsd, can you please create a PR? It would be easier to review and comment. It looks good in the video though I have some suggestions. I will write them here:

1. Hover indication of the range.
2. Max & MIn range validations.
3. Preview format.
4. inline mode.
5. Multiple ranges (advanced feature - not mandatory).

Let's discuss over the PR.

[mustafapsd]

Sure! I've created the PR.

[bogulean]

Hello, is the PR merge still in scope?

[mustafapsd]

Hi @bogulean . I think nobody work it for that now. Maybe I can work for it again. If it is urgent, I think you should look for another package.