search

vlio20 / utils-decorators

Decorators for web and node applications
https://vlio20.github.io/utils-decorators/
MIT License
216 stars 13 forks source link

Improved Types. #128

Closed tripodsgames closed 2 years ago

tripodsgames commented 2 years ago

Implement better types.

Current types(Generic function args): image

New Types(Typed function args): image

tripodsgames commented 2 years ago

@vlio20 Can you check this later?

tripodsgames commented 2 years ago

@vlio20 Casting removed!

vlio20 commented 2 years ago

@tripodsgames I like this PR, as it will help users that are using the functions. Probably less useful for the decorators users.

tripodsgames commented 2 years ago

@tripodsgames I like this PR, as it will help users that are using the functions. Probably less useful for the decorators users.

Yes, now with the typed arguments, it will help alot to avoid bugs. Could you update the Eslint rules? I can't do it right now :watch:

vlio20 commented 2 years ago

Yes. I will merge this one.

vlio20 commented 2 years ago

@tripodsgames can you please resolve the merge conflicts?

tripodsgames commented 2 years ago

@tripodsgames can you please resolve the merge conflicts?

What conflicts are you talking about? Here I didn't have any conflicts.

vlio20 commented 2 years ago

@tripodsgames please see the screenshot: https://prnt.sc/20v4qex Notice that I changed the branch to 2.0.0 as this is a breaking change.

tripodsgames commented 2 years ago

@vlio20 can you check it again?

vlio20 commented 2 years ago

@tripodsgames, I am still prevented from merging https://prnt.sc/20x6t7x

tripodsgames commented 2 years ago

Well, i will make a new pull request.