search

vlitejs / vlite

🦋 vLitejs is a fast and lightweight Javascript library for customizing video and audio player in Javascript with a minimalist theme (HTML5, Youtube, Vimeo, Dailymotion)
https://vlite.js.org
MIT License
266 stars 18 forks source link

Control bar height issue on Firefox #126

Closed mgibbs189 closed 5 months ago

mgibbs189 commented 5 months ago

Describe the bug

Height looks correct in Chrome; way too tall in Firefox.

Seems related to this recent commit: https://github.com/vlitejs/vlite/commit/6fc9c350b88ece7e819575eb8689c41efeedf91e

Not sure why the extra + 10px in the CSS?

Steps to reproduce

Compare the controlbars between Chrome and Firefox. Screenshots below.

Expected behavior

Consistent controlbar heights across browsers

Screenshots and recordings

Chrome 122:

Screenshot 2024-03-18 at 2 25 24 PM

Firefox 123.0.1:

Screenshot 2024-03-18 at 2 25 37 PM

Vlite.js

6.0.2

Browser

Chrome 122, Firefox 123.0.1

OS

macOS 14.4

Additional context

Thanks for your great work on this project, btw :)

yoriiis commented 5 months ago

Hello @mgibbs189, thanks for your feedback, appreciate!

The fix will soon be available in the next release.