vliz-be-opsci / py-sema

Overall parent of all packages involving semantic manipulation of RDF data.
MIT License
0 stars 0 forks source link

added testing and pyrdfstore #49

Closed cedricdcc closed 3 months ago

cedricdcc commented 3 months ago

This PR adds the following:

Issues tackled in this PR:

marc-portier commented 3 months ago

also slightly worrying that the automated tests seem to be failing best to make sure that gets resolved too (strangely my own experience is that tests seem to run nicely locally)

also: the requested split / reposition of the **clean stuff should be accompanied by a reposition of the matching tests I guess

marc-portier commented 3 months ago

@cedricdcc found some time today to give a hint about that reorganiszation of the cleaning code see https://github.com/vliz-be-opsci/py-sema/tree/fix/commons-clean

possibly useful to merge into this branch / PR

marc-portier commented 3 months ago

automated tests still failing -- any clue about the why?

cedricdcc commented 3 months ago

automated tests still failing -- any clue about the why?

It has something todo with the coverage tests from @JotaFan.

Installing collected packages: coverage, coverage-badge Successfully installed coverage-7.5.4 coverage-badge-1.1.1 Traceback (most recent call last): File "/opt/hostedtoolcache/Python/3.12.4/x64/bin/coverage-badge", line 5, in from coverage_badge.main import main File "/opt/hostedtoolcache/Python/3.12.4/x64/lib/python3.12/site-packages/coverage_badge/main.py", line 7, in import pkg_resources

All our tests that are provided succeed.

github-actions[bot] commented 3 months ago

Tests coverage table for a147366 commit.

pycoverage Name Stmts Miss Cover Missing
sema/commons/clean/clean.py 104 0 100.0%
sema/commons/j2/j2_functions.py 102 6 94.12% 59 138 140 172 195 204
sema/commons/j2/rdf_syntax_builder.py 6 0 100.0%
sema/commons/j2/syntax_builder.py 33 3 90.91% 31 39 41
sema/commons/log/loader.py 16 1 93.75% 28
sema/commons/store/build.py 9 1 88.89% 24
sema/commons/store/store.py 181 55 69.61% 150-151 330-333 335-336 338 341-342 349-350 354 357-359 363-365 368-369 372-373 376-377 380-381 398 401 403 410 414-415 417 422-423 426 428 431 436 441 444 447-448 451 455 518 521 524 529 532 535 538 542
TOTAL 451 66 85.37%