Closed cedricdcc closed 7 months ago
here is an obvious element of the confusion:
while nothing changes... making an equivalence between graph_name and config_name that is not at all obvious
given the fact that named_graphs are a concept in rdf, and expected to be uri, I would have thought graph_names are depicting those, and are thus similarly uri already -- hence the remaining confusion that those would need a mapping to from uri
this is how inconsistent variable naming suggests a type-conversion that is not there
the only way for a fellow dev to know is to precisely discover this point of maskerading
MPO
it is entirely unclear what is the semantics and expected use of these two convertor methods is (I mean: I need to check up on the implemementation to realise)
maybe take some inspiration from: https://github.com/vliz-be-opsci/py-sync-fs-triples/blob/main/syncfstriples/service.py#L25
that also allows for having a base to be injected
make sure you have clear semantics separating the two worlds you are converting between
so maybe name things GraphTaskNameMapper with ng_to_taskname(ng) versus taskname_to_ng(taskname)