search

vliz-be-opsci / py-trav-harv

python module that will allow an enduser to perform link traversal on a triple store.
0 stars 0 forks source link

Make config file location that is inserted into the admin graph be the relative path to the config folder location #44

Closed cedricdcc closed 1 month ago

cedricdcc commented 2 months ago

Right now the path that is inserted into the admin graph is the whole path to the config file instead of the relative path. uri=urn%3Atraversal-harvesting%3AC%253A%255CUsers%255Ccedricd%255CDocuments%255CGitHub%255CpyTravHarv%255Ctests%255Cconfig%255Cbase_test.yml

must become => urn:config%255Cbase_test.yml

Also quote escaping must also be reconsidered to have more safe characters

marc-portier commented 2 months ago

something along these lines is available already

1/ syncfs has something for relative paths:

https://github.com/vliz-be-opsci/py-sync-fs-triples/blob/9cf5ded336b2d6f51574f24ecff045a9e1a19f7d/syncfstriples/service.py#L70

just copy for now -- in 004 we can easily push up to a some shared.py

2/ graph-name creaction hanldes safe chars better in the most recent GraphNameMapper

https://github.com/vliz-be-opsci/py-RDF-store/blob/d4dddf1777295688899b990b4e437a6d6622ad4f/pyrdfstore/store.py#L48

so we should get this for free by taking up issue #43

cedricdcc commented 1 month ago

After some searching I have found that I couldn't reproduce this behavior anymore from travharv