vlm / asn1c

The ASN.1 Compiler
http://lionet.info/asn1c/
BSD 2-Clause "Simplified" License
1.05k stars 559 forks source link

WIP: Adding support for variable BACnet encoding rules #246

Open ringlej opened 7 years ago

ringlej commented 7 years ago

I'm working on adding to asn1c support for the variable BACnet encoding rules. As I develop this, I've tried to minimize the BNER code that touches the existing asn1c code base by putting most of the code in separate *_bner.c files. This is to reduce the number of merge conflicts I encounter as I keep upto date with your master branch. The BNER en/decoder is not ready for prime time yet. But while I work on this would you be accepting of a patch for some #ifdef'd code where I do need to touch the skeleton code base? It would help reduce even further merge conflicts if your code already has the #ifdef ASN_ENABLE_BNER_SUPPORT code already in it. Of course this code will be inert on your end since you won't have ASN_ENABLE_BNER_SUPPORT defined.

Regards, Jon

vlm commented 7 years ago
  1. Yes, doing it in the manner OER was implemented (mostly separate files, proper ifdef'ing) is fine.
  2. Where can one get the BACnet encoding rules' refererence?
ringlej commented 7 years ago

It can be obtained (for purchase) from http://www.techstreet.com/ashrae/standards/ashrae-135-2016?product_id=1918140 The encoding rules are in section 20. The asn1 is in section 21 I have a script that uses ghostscript and some sed rules to extract the bacnet asn1 out of the 135-2016.pdf that you provide to the script. I plan on creating a github repo that contains this script in the near future. But you would need to obtain your own copy of the ashrae 135-2016.pdf to feed to the script.