vlocityinc / vlocity_build

Vlocity Build is a command line tool to export and deploy Vlocity DataPacks in a source control friendly format through a YAML Manifest describing your project. Its primary goal is to enable Continuous Integration for Vlocity Metadata through source control. It is written as a Node.js module.
MIT License
113 stars 96 forks source link

FlexCard Compilation Error #475

Closed lotusboy closed 10 months ago

lotusboy commented 2 years ago

Hi,

As part of our vlocity deployment, we have 3 FlexCards which are failing to compile and so cannot subsequently be deployed. Omniscripts are compiling successfully.

Interestingly, if I set lwcCompilerVersion: "890.331", meaning the legacy method is used, the FlexCards get compiled and deployed successfully.

Vlocity Build v1.15.3 Vlocity version 890.331

Log showing the first FlexCard error: ... Loading @vlocity-ins/flexcard-compiler@890.331
Compiling Flexcard with FlexCard ID: >> a6J0E000002GcOkUAK
/usr/local/lib/node_modules/vlocity/node_modules/runtime-plugin-manager-clone/dist/src/PluginVm.js:74 throw new Error("Invalid javascript file " + filePath); ^

Error: Invalid javascript file /Users/sloftus/Documents/git/smartchassis/vlocity-temp/plugins/copy-anything/dist/index.cjs at PluginVm.load (/usr/local/lib/node_modules/vlocity/node_modules/runtime-plugin-manager-clone/dist/src/PluginVm.js:74:19) at PluginManager.load (/usr/local/lib/node_modules/vlocity/node_modules/runtime-plugin-manager-clone/dist/src/PluginManager.js:553:24) at PluginManager.require (/usr/local/lib/node_modules/vlocity/node_modules/runtime-plugin-manager-clone/dist/src/PluginManager.js:191:21) at PluginVm.sandboxRequire (/usr/local/lib/node_modules/vlocity/node_modules/runtime-plugin-manager-clone/dist/src/PluginVm.js:252:33) at Object.assign.resolve (/usr/local/lib/node_modules/vlocity/node_modules/runtime-plugin-manager-clone/dist/src/PluginVm.js:178:25) at /Users/sloftus/Documents/git/smartchassis/vlocity-temp/plugins/less/lib/less/utils.js:8:23 at /Users/sloftus/Documents/git/smartchassis/vlocity-temp/plugins/less/lib/less/utils.js:127:2 at Script.runInContext (node:vm:139:12) at PluginVm.vmRunScriptInSandbox (/usr/local/lib/node_modules/vlocity/node_modules/runtime-plugin-manager-clone/dist/src/PluginVm.js:136:16) at PluginVm.load (/usr/local/lib/node_modules/vlocity/node_modules/runtime-plugin-manager-clone/dist/src/PluginVm.js:61:22)
...

depill commented 2 years ago

@lotusboy runtime-plugin-manager-clone looks only for the imports ending with js. copy-anything did ( in my mind an API breaking ) change in 2.0.6 that no longer points to the .js but the cjs. Less depends on it with ^.

You can manually fix it by copying copy-anything@2.0.1 into the vlocity-temp/plugins folder while waiting for a fix on this.

AllanOricil commented 2 years ago

relates: https://github.com/vlocityinc/vlocity_build/issues/486

AllanOricil commented 2 years ago

This is where the error is thrown:

https://github.com/davideicardi/live-plugin-manager/blob/79d057ff95af8d466ce363e5a95a5c00c2d7dbd6/src/PluginVm.ts#L44-L61

deanjesper commented 2 years ago

@lotusboy runtime-plugin-manager-clone looks only for the imports ending with js. copy-anything did ( in my mind an API breaking ) change in 2.0.6 that no longer points to the .js but the cjs. Less depends on it with ^.

You can manually fix it by copying copy-anything@2.0.1 into the vlocity-temp/plugins folder while waiting for a fix on this.

When we use copy-anything@2.0.1, we get this error:

abort(ReferenceError: sessionStorage is not defined). Build with -s ASSERTIONS=1 for more info.

Anyone else getting this?

deanjesper commented 2 years ago

Just to add to my above comment, there is an issue in the file: /vlocity-temp/plugins/@omnistudio/flexcard-compiler/src/compiler/flexCardUtility/fetchCustomLabels.js

Lines 8-23 and line 104 mention sessionStorage. If you comment some of those lines out, the compiler will work, although from what I've experienced, the compiler doesn't work well if you're using a Vlocity managed package (vlocity-cmt, vlocity-ins etc)

AllanOricil commented 2 years ago

@centricadean use copy-anything@2.0.6. Im using it and I don't get the problem you experienced. image

and flexcard-compiler@900.458.0 image

deanjesper commented 2 years ago

@centricadean use copy-anything@2.0.6. Im using it and I don't get the problem you experienced. image

Is the compiler working on vlocity-cme for you with copy-anything@2.0.6? @AllanOricil

AllanOricil commented 2 years ago

@centricadean use copy-anything@2.0.6. Im using it and I don't get the problem you experienced. image

Is the compiler working on vlocity-cme for you with copy-anything@2.0.6? @AllanOricil

Yes, but I had to add this version of copy-anything inside ./vlocity-temp/plugins/

The flexcard-compiler had a different error and I had to fix it after it was downloaded. Then I also versioned it inside ./vlocity-temp/plugins so that vlocity-cli doesn't download it again. The issue is that the compiler as is was generating components with namespace c instead of vlocity_cmt.

AllanOricil commented 2 years ago

@centricadean I'm also using vlocity-cli@1.15.6

deanjesper commented 2 years ago

OK will give 2.0.6 a go!

I'm also having an issue with the compiler using namespace c instead of vlocity_cmt. I tried making some changes in the temp folder for the compiler but some components like c:spinner aren't getting compiled as vlocity_cmt-spinner...

492

deanjesper commented 2 years ago

@AllanOricil I'm running copy-anything@2.0.6 and I'm getting this error:

/usr/local/lib/node_modules/vlocity/node_modules/runtime-plugin-manager-clone/dist/src/PluginVm.js:74
            throw new Error("Invalid javascript file " + filePath);

When I downgrade to copy-anything@2.0.1 I get an error to do with sessionStorage in this file:

/vlocity-temp/plugins/@vlocity-cme/flexcard-compiler/src/compiler/flexCardUtility/fetchCustomLabels.js

Using vlocity@1.15.6 too

AllanOricil commented 2 years ago

@AllanOricil I'm running copy-anything@2.0.6 and I'm getting this error:

/usr/local/lib/node_modules/vlocity/node_modules/runtime-plugin-manager-clone/dist/src/PluginVm.js:74
            throw new Error("Invalid javascript file " + filePath);

When I downgrade to copy-anything@2.0.1 I get an error to do with sessionStorage in this file:

/vlocity-temp/plugins/@vlocity-cme/flexcard-compiler/src/compiler/flexCardUtility/fetchCustomLabels.js

Using vlocity@1.15.6 too

@centricadean Inside copy-anything you must ""append"" .js to their file names

You have to end up having these files:

index.cjs.js index.es.js

deanjesper commented 2 years ago

Thanks @AllanOricil - that works, but then I get the sessionStorage error again. I'm hitting this error when trying to deploy the LWC cart FlexCards which I think use custom labels.

Screenshot 2022-07-27 at 1 40 02 pm

AllanOricil commented 2 years ago

This is possibly a new bug. Could you open an issue describing minimal steps to reproduce this error you are experiencing. This will help people to fix it. I can look at it later. Could you also create a custom vlocity component that uses custom labels and see if the same issue happens? Maybe it is not something related to the cart component only.

deanjesper commented 2 years ago

Raised a new issue, will try a custom Vlocity component with custom labels shortly

KevinGossentCap commented 1 year ago

Just tried with latest VBT and latest SFI version (CMT 240.8) Took only 1 omniscript & 1 vlocitycard OmniScript/CPQ_cartConfigurator_Multi-Language VlocityCard/cpqProductTileList

OS compiles OK Card gives a strange error Compiling Flexcard with FlexCard ID: >> a5a6S000007JdoAQAS APEX_ERROR: System.LimitException: JSON string exceeds heap size limit

(System Code) at HttpApi.getError (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\jsforce\lib\http-api.js:250:13) at C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\jsforce\lib\http-api.js:95:22 at tryCallOne (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\promise\lib\core.js:37:12) at C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\promise\lib\core.js:123:15 at flush (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\asap\raw.js:50:29) at process.processTicksAndRejections (node:internal/process/task_queues:77:11) { errorCode: 'APEX_ERROR' } The error is NOT BLOCKING O_O how can we know if it's ok ?

LWC created and deployed but definitely not safe given the error

AllanOricil commented 1 year ago

@KevinGossentCap vlocity build tool does not work like the Metadata API does. There is no such thing as Deploy All or None. You have to deploy everything that has changed over and over again until all errors are fixed. Beside that, in your CI pipeline, you need to read the vlocity job output file to check if there were errors or not, and exit 1 if there were errors. It is a json file which contains everything that was processed by the cli.

KevinGossentCap commented 1 year ago

Hi @AllanOricil You should look and read back the subject of this ticket. It's all about localCompile, the feature proposed since 1 year ago and that is still struggling to work on vlocity component themselves. To make it clearer, here is more of my log where we see clearly that it is the VBT process locally compiling the vlocityCard which is giving the ERROR. And what I ask is "how can we have trust/faith in what's deployed if the job creating what's deployed return such an error

Loading @vlocity-cme/omniscript-lwc-compiler@latest Starting OmniScript LWC Compilation >> OmniScript/CPQ_cartConfigurator_Multi-Language (a336S000003FaBbQAK) Retrieving OmniScript definition Compiling OmniScript LWC Component Specified path does not exist. Creating it now... LWC for FlexCard will be compiled at the end >> VlocityCard/cpqProductTileList Salesforce Org >> sfi_esm_win23 Version Info >> v1.16.1 vlocity_cmt 900.468 Current Status >> Deploy Remaining >> 0 Success >> 2 Error >> 0 Elapsed Time >> 1m 4s Migrated 2 items >> Deploying Loading @vlocity-cme/flexcard-compiler@latest Compiling Flexcard with FlexCard ID: >> a5a6S000007JdoAQAS APEX_ERROR: System.LimitException: JSON string exceeds heap size limit

(System Code) at HttpApi.getError (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\jsforce\lib\http-api.js:250:13) at C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\jsforce\lib\http-api.js:95:22 at tryCallOne (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\promise\lib\core.js:37:12) at C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\promise\lib\core.js:123:15 at flush (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\asap\raw.js:50:29) at process.processTicksAndRejections (node:internal/process/task_queues:77:11) { errorCode: 'APEX_ERROR' } Specified path does not exist. Creating it now... Deploying generated LWC components Using salesforce-alm Running source:convert Source was successfully converted to Metadata API format and written to the location: C:\GitRepos\HubOne\defaultEmpty_CPQ_LWC_240\vlocity-temp\mdapi source:convert ended successfully Running mdapi:deploy Job ID | 0Af6S00000pzrnxSAA MDAPI PROGRESS | ████████████████████████████████████████ | 2/2 Components mdapi:deploy ended successfully Metadata Deployed >> LightningComponentBundle/cPQCartConfiguratorMultiLanguage Metadata Deployed >> LightningComponentBundle/cfCpqProductTileList Finalizing Deployment Salesforce Org >> sfi_esm_win23 Version Info >> v1.16.1 vlocity_cmt 900.468 Current Status >> Deploy Remaining >> 0 Success >> 4 Error >> 0 Elapsed Time >> 3m 1s Migrated 4 items >> Deploying Job Complete >> Deploy 3m 1s Deploy success: 4 Completed

AllanOricil commented 1 year ago

@KevinGossentCap would you be able to zip this flexicard datapack and paste it here. I need to use it to debug the compiler. The error message does not help much to determine the root cause of the problem.

AllanOricil commented 1 year ago

@KevinGossentCap could you also run vlocity cli again but with --verbose

image

I'm almost certain it won't show the errors I need because the compiler has its verbose prop hardcoded to false, but let's give it a try.

image

My guess is that one of these custom rest services is causing that system limit exception

image

Could you also open your debug logs and try to identify which apex method throws this exception while the compiler is running APEX_ERROR: System.LimitException: JSON string exceeds heap size limit

KevinGossentCap commented 1 year ago

@KevinGossentCap would you be able to zip this flexicard datapack and paste it here. I need to use it to debug the compiler. The error message does not help much to determine the root cause of the problem.

Hi @AllanOricil they are both from "industry CPQ LWC" static ressources. So both provided directly by vlocity/Salesforce. I find it hard to believe they "fixed" the "sessionStorage" error without testing that there was no other error hidden by the first one...

KevinGossentCap commented 1 year ago

@KevinGossentCap could you also run vlocity cli again but with --verbose

image

I'm almost certain it won't show the errors I need because the compiler has its verbose prop hardcoded to false, but let's give it a try.

image

My guess is that one of these custom rest services is causing that system limit exception

image

Could you also open your debug logs and try to identify which apex method throws this exception while the compiler is running APEX_ERROR: System.LimitException: JSON string exceeds heap size limit

Hi again, I tested verbose and not much additional information, either on screen or logfile. On screen I only have an additional information (the Result json I'll paste at the end of this answer). In the log I have nothing at all (not even the APEX error)

Here for the verbose output giving the additional result json and still the APEX error:

  LWC for FlexCard will be compiled at the end >> VlocityCard/cpqProductTileList
  Result >> {"Status":"Deleted","VlocityDataPackId":"a5d6S000001Eg9zQAC"}
  Salesforce Org >> sfi_esm_win23
  Version Info >> v1.16.1 vlocity_cmt 900.468
  Log File >> vlocity-temp\logs\vlocity-YAML-CPQ_LWC_3_test-yaml-2022-11-30T07-42-56-768Z-Deploy.yaml
  Current Status >> Deploy
  Remaining >> 0
  Success >> 2
  Error >> 0
  Elapsed Time >> 0m 53s
  Migrated 2 items >> Deploying
  Saving File Start
  Saving File End >> 119
  Checking Valid Imports Start
  Get Package Version
  Loading @vlocity-cme/flexcard-compiler@latest
  Compiling Flexcard with  FlexCard ID:  >> a5a6S000007JdoAQAS
APEX_ERROR: System.LimitException: JSON string exceeds heap size limit

(System Code)
    at HttpApi.getError (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\jsforce\lib\http-api.js:250:13)
    at C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\jsforce\lib\http-api.js:95:22
    at tryCallOne (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\promise\lib\core.js:37:12)
    at C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\promise\lib\core.js:123:15
    at flush (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\asap\raw.js:50:29)
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11) {
  errorCode: 'APEX_ERROR'
}
Specified path does not exist. Creating it now...
  Deploying generated LWC components
  Using salesforce-alm
  Running source:convert
Using resolved username kevin.gossent-0586686738@industryapps.com from alias sfi_esm_win23
AllanOricil commented 1 year ago

@KevinGossentCap this does not help. I don't have means to repro your error, so Im going to guide you so that we can at least discover which apex code is causing this exception you are seeing.

Do you know where theflexcard-compiler package is located, right? If not, it is in the root of your sfdx project, in the following dir vlocity-temp/plugins/@vlocity-cme/flxcard-compiler

Could you override a function called executeMethod in vlocity-temp/plugins/@vlocity-cme/flxcard-compiler/src/compiler/flexCardUtils/api.js using the one I pasted below.

function executeMethod(methodName, inputMap, params) {
  const data = {
    sClassName: _namespaceDotNotation + "FlexCardCompiler",
    sMethodName: methodName,
    input: inputMap ? JSON.stringify(inputMap) : "{}",
    options: inputMap ? JSON.stringify(inputMap) : "{}",
    ...params
  };

  console.log('executeMethod data');
  console.log(JSON.stringify(data));

  let url = `${_namespaceSlashNotation}/v1/GenericInvoke/`;

  if (_connection) {
    return _connection.apex.post(url, data, (err, res) => {
      if (err) {
        console.log(`Error while executing: ${methodName}`);
        return console.error(err);
      }
      return res;
    });
  }

  return Promise.reject(
    "Connection not set. Please do so using setApi method."
  );
}

Then run the cli again and see if it prints more error messages.

KevinGossentCap commented 1 year ago

Hi @AllanOricil , here is the new output

  Loading @vlocity-cme/flexcard-compiler@latest
  Compiling Flexcard with  FlexCard ID:  >> a5a6S000007JdoAQAS
executeMethod data
{"sClassName":"vlocity_cmt.FlexCardCompiler","sMethodName":"getAllCardsByRecordType","input":"{\"recordType\":\"Flex\"}","options":"{\"recordType\":\"Flex\"}"}
executeMethod data
{"sClassName":"vlocity_cmt.FlexCardCompiler","sMethodName":"getLWCBundles","input":"{\"nextRecordsUrl\":\"\"}","options":"{\"nextRecordsUrl\":\"\"}"}
executeMethod data
{"sClassName":"vlocity_cmt.FlexCardCompiler","sMethodName":"getUserProfile","input":"{}","options":"{}"}
Error while executing: getAllCardsByRecordType
APEX_ERROR: System.LimitException: JSON string exceeds heap size limit

(System Code)
    at HttpApi.getError (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\jsforce\lib\http-api.js:250:13)
    at C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\jsforce\lib\http-api.js:95:22
    at tryCallOne (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\promise\lib\core.js:37:12)
    at C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\promise\lib\core.js:123:15
    at flush (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\asap\raw.js:50:29)
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11) {
  errorCode: 'APEX_ERROR'
}
executeMethod data
{"sClassName":"vlocity_cmt.FlexCardCompiler","sMethodName":"getCustomLabels","input":"{\"customLabels\":[\"CPQSeeDetailsLabel\",\"CPQPriceLabel\",\"OneTime\",\"Recurring\",\"CPQAddToCart\",\"CPQConfigure\",\"CPQOneTimeLabel\"]}","options":"{\"customLabels\":[\"CPQSeeDetailsLabel\",\"CPQPriceLabel\",\"OneTime\",\"Recurring\",\"CPQAddToCart\",\"CPQConfigure\",\"CPQOneTimeLabel\"]}"}
executeMethod data
{"sClassName":"vlocity_cmt.FlexCardCompiler","sMethodName":"upsertAttachment","input":"{\"sParentId\":\"a5a6S000007JdoAQAS\",\"sAttName\":\"a5a6S000007JdoAQAS.css\",\"sContent\":\"\",\"bEncoded\":false}","options":"{\"sParentId\":\"a5a6S000007JdoAQAS\",\"sAttName\":\"a5a6S000007JdoAQAS.css\",\"sContent\":\"\",\"bEncoded\":false}"}
Specified path does not exist. Creating it now...
  Deploying generated LWC components
  Using salesforce-alm
  Running source:convert
Using resolved username kevin.gossent-0586686738@industryapps.com from alias sfi_esm_win23
AllanOricil commented 1 year ago

@KevinGossentCap

Now you can open a ticket to vlocity so that they can fix that apex method that is failing. 😄

u can't fix this apex class because it is inside a managed package.

deanjesper commented 1 year ago

Hi @KevinGossentCap and @AllanOricill, the issue with the Apex class is due to be fixed in the next patch (240.9) which is due to be released around 9 December.

KevinGossentCap commented 1 year ago

@AllanOricil I'm just hopping that, once the "new first error" is solved, the following will be fully tested to produce a version which can go through all omniscripts & vlocitycards provided with industry CPQ LWC + ESM...

KevinGossentCap commented 1 year ago

@centricadean @AllanOricil I've just tested again with 240.10 Still the same error....... (I expect the class to be corrected, not a component change to take back from industry CPQ LWC in the static ressources)

AllanOricil commented 1 year ago

@KevinGossentCap could you share the output?

What do you mean exactly when you say

"(I expect the class to be corrected, not a component change to take back from industry CPQ LWC in the static ressources)"

KevinGossentCap commented 1 year ago

@AllanOricil nothing changed at all, same errror in the same class (I had to add back the console logs to see that)

  Loading @vlocity-cme/flexcard-compiler@latest
  Compiling Flexcard with  FlexCard ID:  >> a5a6S000007JdoAQAS
Error while executing: getAllCardsByRecordType
{"sClassName":"vlocity_cmt.FlexCardCompiler","sMethodName":"getAllCardsByRecordType","input":"{\"recordType\":\"Flex\"}","options":"{\"recordType\":\"Flex\"}"}
APEX_ERROR: System.LimitException: JSON string exceeds heap size limit

(System Code)
    at HttpApi.getError (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\jsforce\lib\http-api.js:250:13)
    at C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\jsforce\lib\http-api.js:95:22
    at tryCallOne (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\promise\lib\core.js:37:12)
    at C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\promise\lib\core.js:123:15
    at flush (C:\KGO_Tools\node-v18-win-x64\node_modules\vlocity\node_modules\asap\raw.js:50:29)
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11) {
  errorCode: 'APEX_ERROR'
}

My remark was that I did not go through taking back vlocity provided static ressources that gives us the components I'm using to test the localCompile. they are part of vlocity industry CPQ LWC (and ESM). As the error was an APEX error, I expected as said by @centricadean that they'd fix the Apex class.

AllanOricil commented 1 year ago

@KevinGossentCap but what did you say about the static resouces? I did not get it at all

KevinGossentCap commented 1 year ago

My remark was that I did not go through taking back vlocity provided static ressources that gives us the components I'm using to test the localCompile. they are part of vlocity industry CPQ LWC (and ESM). As the error was an APEX error, I expected as said by @centricadean that they'd fix the Apex class.

I edited my post to give the answer for that part

My remark was that I did not go through taking back vlocity provided static ressources that gives us the components I'm using to test the localCompile. they are part of vlocity industry CPQ LWC (and ESM). As the error was an APEX error, I expected as said by @centricadean that they'd fix the Apex class.

AllanOricil commented 1 year ago

@KevinGossentCap is the deployment ok, even with this error? I mean, are u able to see all your flexicarda in your sandbox?

KevinGossentCap commented 1 year ago

@AllanOricil The salesforce deployment is successfull, but no way to be sure it's 100% produced as expected for the moment. When not overloaded, I'll maybe try to force myself to retrieve both localcompile and pupetteer versions to compare them...

KevinGossentCap commented 1 year ago

@AllanOricil @centricadean I can confirm that the localCompile one is different from the pupetteer one... image image image image the left one is localCompile

AllanOricil commented 1 year ago

@KevinGossentCap the missing custom labels refs are part of another issue. They are already working on a fix for that. I could actually fix it by publishing another local compiler package to npm, but I would also have to change the cli to let developers reference my package, isntead of the one from vlocity. The way vlocity implemented how labels are fetched in lwc is really not ideal. It takes a server round trip just to load them. I believe the proper approach would be to actually build the component with labels in it. It would make components load faster.

thvd commented 1 year ago

@KevinGossentCap Can confirm the same. Logged case with ID: Case #43776753.

deanjesper commented 1 year ago

Yep sadly this issue is not fixed in 240.9. I have a case open and they're saying it will be fixed in 240.11. I won't hold my breath though. Please do raise cases and raise this as an issue as I'm sure a case from each customer will help push Salesforce to rethink their testing practices before releasing and getting our hopes up.

KevinGossentCap commented 1 year ago

Hi @centricadean @AllanOricil @manas-sf , I've just tested with latest VBT and latest winter 23 patch (240.11). Some of the more blocking errors are solved BUT there is a more problematic resulting issue now

You can easily test using the SFI provided industry CPQ LWC. The LWC are not exactly the same. There is even one that is so different that it doesn't even deploy...

deanjesper commented 1 year ago

Hi @centricadean @AllanOricil @manas-sf , I've just tested with latest VBT and latest winter 23 patch (240.11). Some of the more blocking errors are solved BUT there is a more problematic resulting issue now

  • Apex error not there anymore
  • localCompiled LWC are not the same as browser compile LWC

You can easily test using the SFI provided industry CPQ LWC. The LWC are not exactly the same. There is even one that is so different that it doesn't even deploy...

Yep, sadly there are still issues with the local compiler. If you compile a Multi-Language FlexCard, then the labels aren't generated and just display as {Label.xxx} when you render the LWC.

I have no more updates from Salesforce on this. The saga continues...

manas-sf commented 1 year ago

Thanks for the feedback. We have Case#35690448 with FlexCard team and they looking into it.

deanjesper commented 1 year ago

@manas-sf there is also Case #43894399

thvd commented 1 year ago

@manas-sf and there is also case #43776753. Already closed, but not solved.

deanjesper commented 1 year ago

@manas-sf and there is also case #43776753. Already closed, but not solved.

Closed but not solved - great!

thvd commented 1 year ago

Does anyone already run with 242? I have been told (tentative/safe harbour/...) it should have been solved in 242. Did anyone test already?

pawel-id commented 1 year ago

I would rephrase @thvd question: does anyone use local compilation? On which version if possible?

Reading this thread makes the impression that it just doesn’t work. I’m desperately searching for this possibility. We have huge Vlocity project (hundreds omniscripts, flex cards, etc). Currently we are on Spring’22 (900.456). In our case full deployment of just this Vlocity part takes 3-4 hours. And most of the deployment time it is compilation and activation of LWC stuff via puppeteer. Moreover it is very vulnerable to all network and Salesforce instabilities. Then it fails frequently. With growing project size we are approaching the moment where we won’t be able to deploy Vlocity at all. Then local compilation could solve the problem, but does it really work? Anyone?

thvd commented 1 year ago

Currently it works for us. Latest version of everything. Works ok. As long as the repository isn't down. Will try to list exact version numbers Monday.

Op za 4 mrt. 2023 16:58 schreef Paweł Idczak @.***>:

I would rephrase @thvd https://github.com/thvd question: does anyone use local compilation? On which version if possible?

Reading this thread makes the impression that it just doesn’t work. I’m desperately searching for this possibility. We have huge Vlocity project (hundreds omniscripts, flex cards, etc). Currently we are on Spring’22 (900.456). In our case full deployment of just this Vlocity part takes 3-4 hours. And most of the deployment time it is compilation and activation of LWC stuff via puppeteer. Moreover it is very vulnerable to all network and Salesforce instabilities. Then it fails frequently. With growing project size we are approaching the moment where we won’t be able to deploy Vlocity at all. Then local compilation could solve the problem, but does it really work? Anyone?

— Reply to this email directly, view it on GitHub https://github.com/vlocityinc/vlocity_build/issues/475#issuecomment-1454785665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHNXDZGJ54UQXMUHZINQTTW2NRBFANCNFSM5YUVUA5Q . You are receiving this because you were mentioned.Message ID: @.***>

KevinGossentCap commented 1 year ago

Not completely sure if it works as, if I follow my shared procedure

We can see that there are A LOT of LWC not produced. To really test, I'll have to produce a clean sandbox, full manually install vlocity managed package and then full manually do all CPQ LWC + ESM steps and then compare between trial ORG and produced sandbox...

KevinGossentCap commented 1 year ago

Replying to myself, it still violently crashes when trying to use it for initial vlocity CME industry CPQ LWC deployment...

KevinGossentCap commented 1 year ago

To sum it up