search

vlocityinc / vlocity_build

Vlocity Build is a command line tool to export and deploy Vlocity DataPacks in a source control friendly format through a YAML Manifest describing your project. Its primary goal is to enable Continuous Integration for Vlocity Metadata through source control. It is written as a Node.js module.
MIT License
115 stars 98 forks source link

npmAuthKey could come from a env variable #510

Closed AllanOricil closed 2 years ago

AllanOricil commented 2 years ago

devs should not be able to version npm auth keys in their repos, specially in job definitions. This key should come from an env variable, such as VLOCITY_NPM_AUTH_KEY. This way the cli does not even need to care about decrypting the key.

Or

Just remove npm auth key at all, and pack OS and Flexcards compilers as dependencies. Is there a reason for allowing developers to choose an specific compiler version? Maybe we can improve this if we know the actual reason.

AllanOricil commented 2 years ago

@rutlabaga any suggestions or comments about this? I could do it.