search

vloup / sgfork

Automatically exported from code.google.com/p/sgfork
GNU General Public License v2.0
0 stars 1 forks source link

Removal of a temporary solution to disable shadow projection bug #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Description:
    // A temporary solution to disable shadow projection bug
    // in the Quake 3 engine, as it is a form of cheating.
    if (cg_shadows.integer == 2 && !cg_cheats
    && CG_Cvar_VariableInteger("r_stencilbits") >= 4) {
        CG_Printf("cg_shadows: 2 -> 1\n");
        cg_shadows.integer = 1;
        trap_Cvar_Set("cg_shadows", "1");
    }
@CG_Player()

Seems the code is rudiment and some kind of hack.
To be removed?

Original issue reported on code.google.com by igorpana...@gmail.com on 20 Aug 2009 at 3:19

GoogleCodeExporter commented 9 years ago 
The following code also:
    if ( cg_shadows.integer == 3 && shadow && cg_cheats) {
        renderfx |= RF_SHADOW_PLANE;
    }
    renderfx |= RF_LIGHTING_ORIGIN;

Seems the cheat checking is redundant.

Original comment by igorpana...@gmail.com on 20 Aug 2009 at 3:29

GoogleCodeExporter commented 9 years ago 
To be removed.
If in any case we met the shadow troubles, better to solve them instead.

Original comment by igorpana...@gmail.com on 20 Aug 2009 at 3:46

GoogleCodeExporter commented 9 years ago 
Fixed at r8.

Original comment by igorpana...@gmail.com on 20 Aug 2009 at 4:39