search

vlsi / ksar

A sar grapher, fork of http://sourceforge.net/projects/ksar/
Other
246 stars 60 forks source link

Support adding earlier values after newer ones. #147

Closed ams-tschoening closed 6 years ago

ams-tschoening commented 6 years ago

Setting startofgraph and endofgraphwas duplicated between all parsers, so I centralized it in base class AllParsers and additionally renamed a bit to to better fit Java naming styles. Afterwards I was easily able to add that newer timestamps not only change endofgraph, but startofgraph as well, so one is able to add older sar files to existing graphs. That didn't work before. Adding older data seems to have simply been ignored somewhere, OTOH AllParser.setDate handled storing an earlier timestamp AND a later one already. So the implementation of both values is now in line.

Pitterling commented 6 years ago

Thanks, please fix the 3 checkstyle errors and i'm going to merge

[ant:checkstyle] [ERROR] /home/travis/build/vlsi/ksar/src/main/java/net/atomique/ksar/AllParser.java:62: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/travis/build/vlsi/ksar/src/main/java/net/atomique/ksar/AllParser.java:63: At-clause should have a non-empty description. [NonEmptyAtclauseDescription]
[ant:checkstyle] [ERROR] /home/travis/build/vlsi/ksar/src/main/java/net/atomique/ksar/AllParser.java:81: 'method def modifier' have incorrect indentation level 0, expected level should be 2.
ams-tschoening commented 6 years ago

Done, please review again.

Pitterling commented 6 years ago

Thanks for your contribution