search

vlsi / ksar

A sar grapher, fork of http://sourceforge.net/projects/ksar/
Other
246 stars 59 forks source link

NaturalComparator adjust Regex WORD_PATTERN, remove isDigit #249

Closed Pitterling closed 1 year ago

Pitterling commented 2 years ago

adjust Regex - find several chars at once like for digits remove variable isDigit copyright 2022

vlsi commented 2 years ago

Could you add tests to cover the change? What is the reason?

Pitterling commented 2 years ago

no futher tests required - but all test succeed we typically compare anything like dev8-xxx to dev8-yyy or ethX to ethY .. current implementation would compare char by char e,t,h .. this here will directly compare eth and eth

Pitterling commented 2 years ago

still any objections ?

vlsi commented 2 years ago

Will review shortly