search

vlsi / ksar

A sar grapher, fork of http://sourceforge.net/projects/ksar/
Other
249 stars 60 forks source link

migrate from log4j2 to logback #266

Closed Pitterling closed 1 year ago

Pitterling commented 1 year ago

@vlsi please check why 'JDK8' is failing. Thx

vlsi commented 1 year ago

Thanks. I guess we can bump the minimal Java to 11 if you like. However, will check the failure tomorrow

vlsi commented 1 year ago

The failure is 'class file has wrong version 55.0, should be 52.0' which means logback is built for Java 11.

Pitterling commented 1 year ago

You are right .. https://logback.qos.ch/dependencies.html Version 1.3 is made for Java8; 1.4 for Java11 .. both are feature identical .. i just need to pick the 1.3 version.

On the other side, i personally dont care if Java8 is still supported .. don't know how others are thinking about ..

vlsi commented 1 year ago

I guess moving to 11 minimum would ease these types of issues. I think 11 should be just fine from the users' point of view

Pitterling commented 1 year ago

Ok, but let's get 5.2.4 out first and target JDK11 for the next 6.0 release.