vlukiyanov / pt-avitm

PyTorch implementation of AVITM (Autoencoding Variational Inference For Topic Models)
MIT License
36 stars 6 forks source link

sklearn_api.py variable names and max/min bug #22

Closed vlukiyanov closed 5 years ago

vlukiyanov commented 5 years ago

In pt-avitm/ptavitm/sklearn_api.py samples, documents = X.shape should probably be called something less confusing, and in call to train, the line sampler=WeightedRandomSampler(torch.ones(samples), max(samples, self.samples)) should have min there instead.