search

vmagamedov / grpclib

Pure-Python gRPC implementation for asyncio
http://grpclib.readthedocs.io
BSD 3-Clause "New" or "Revised" License
936 stars 92 forks source link

grpclib does memory leak due h2_connection._closed_streams #31

Closed hellysmile closed 6 years ago

hellysmile commented 6 years ago

Hey, it is mostly replication issue found in https://github.com/python-hyper/hyper-h2/issues/1163

Is there any way recreate client connection over time or after some amount of finished requests?

hellysmile commented 6 years ago

Or maybe stream_id generated wrong, does they need to be generated for each request? https://github.com/vmagamedov/grpclib/blob/master/grpclib/protocol.py#L246

vmagamedov commented 6 years ago

Hi! Yes, stream_id should be generated for every request.