Thanks a lot for your submissions!
This is a first important feedback about both of your submissions for bounties #12 and #13.
We are working on a full review for them, but, while we do it, we need to point out an important issue asap. So you have some time to fix it.
As mentioned in the bounties #12 and #13, the objective was to use our existing Email vc issuer. It was required to do the integration of the Email Issuer into the Id Manager.
We also recommend it to be used as the base for the SMS VC Issuer, but this is not mandatory.
So, this initial feedback would be:
Mandatory: Use Email vc issuer server and codebase for the Integration into Id Mgr
About SMS vc issuer:
2.1. Mandatory: if not using the Email vc issuer as codebase, keep it in a separate repo named /sms-vc-issuer or implement a new API in the same repo for verifying phone numbers.
2.2. Recommendation (not mandatory): create the sms-vc-issuer by using the /email-vc-issuer codebase
Hi @vmandal!
Thanks a lot for your submissions! This is a first important feedback about both of your submissions for bounties #12 and #13.
We are working on a full review for them, but, while we do it, we need to point out an important issue asap. So you have some time to fix it.
As mentioned in the bounties #12 and #13, the objective was to use our existing Email vc issuer. It was required to do the integration of the Email Issuer into the Id Manager. We also recommend it to be used as the base for the SMS VC Issuer, but this is not mandatory.
So, this initial feedback would be:
Summary:
If you have any questions about this, feel free to reply here, or via the public RSK Slack.
Thanks!