Open Daribon opened 1 year ago
Videos of reviving dead pet when its still spawned from Joana in vanilla patch 1.9.2: https://youtu.be/zssuKMWa-vg?t=2033 https://youtu.be/PLENf2XHZbI?t=5958 It confirms that pet should despawn instantly when you cast revive pet.
Another video showing pet instantly despawn when using revive pet in vanilla: https://youtu.be/W_BgaXLI7Dc?t=95 Another having hunter having dead pet instantly despawn in vanilla by using revive pet: https://youtu.be/1gMZRxSYNiE?t=105
Pet dies in this video and Joana runs away from the pet and it despawns, from vanilla patch 1.9.2: https://youtu.be/fEPo050WscM?t=13074
Joana stables the dead pet in vanilla patch 1.9.2: https://youtu.be/Ehxo0J_87iI?t=17 It is currently not possible to stable a dead pet on vmangos. The pet will display at stable master on vmangos but any attempt to drag it into stable master will fail.
Joana takes the dead pet out from stable, tries to use Call Pet only to get message "Your pet is dead": https://youtu.be/Ehxo0J_87iI?t=622 He then use revive pet and it summons the pet.
Hunter summoning dead despawned pet in vanilla by using revive pet: https://youtu.be/9Sh4k3rAZSE?t=88 Another hunter summong dead despawned pet in vanilla by using revive pet: https://youtu.be/1gMZRxSYNiE?t=227
"This will not work if your pet is dead"
https://wowpedia.fandom.com/wiki/Call_Pet?direction=next&oldid=23783 Revision as of 02:07, 5 August 2005 - Patch 1.6.1 - it was removed from the wiki 2008
Noticed that cmangos fixed call pet and revive pet spells some years ago.
🐛 Bug report
If your pet has died and despawned you can currently summon the dead pet using Call Pet. The pet will still be dead when summoned.
If you cast Revive Pet on a pet that is dead but not despawned, the dead pet will only get removed once the channeling is done and the pet is resurrected.
You are currently unable to resurrect a dead pet that has despawned without first using Call Pet to summon the corpse.
If you try to use Call Pet while the pet is dead but not despawned you will get the message: "You already control a summoned creature"
If your pet is alive but dismissed and try to ressurect it, you will currently get the error message: "You do not have a pet"
If you use Call Pet with no pet you currently get no error and the spell will cast, but not summon anything.
If you use Revive Pet with no pet you will get the message: "You have no pet."
Expected behavior
If your pet has died and despawned you should not be able to summon it. When a pet has died and despawned the hunter should only need to revive the pet.
Casting Call Pet with pet dead and despawned should give you the following error message: The error is PETTAME_DEAD = Your pet is dead.
Casting Call Pet with pet dead and not despawned should give you the following error message: Using Call Pet with dead pet but not despawned is currently working correctly in VMaNGOS.
Casting Revive pet with pet alive should give you the following error message: VMaNGOS currently uses SPELL_FAILED_ALREADY_HAVE_SUMMON = You already control a summoned creature Correct is PETTAME_ANOTHERSUMMONACTIVE = You have an active summon already
If you cast Revive Pet on a dead pet that has not yet respawned, the dead pet should instantly respawn as soon as the cast starts.
If you try to use Revive Pet while a pet is alive but dimissed, you should get the error: Currently on VMaNGOS you get the error message: SPELL_FAILED_NO_PET = You do not have a pet Correct is PETTAME_NOTDEAD = Your pet is not dead
If you attempt to use Call Pet with no pet at all you should get the following error: Currently on VMaNGOS you get no error message and Call Pet spell cast is completed, but no pet summoned.
If you attempt to use Revive Pet with no pet at all you should get the following error: Current error message on VMaNGOS is: SPELL_FAILED_NO_PET = You do not have a pet Correct error message should be: PETTAME_NOPETAVAILABLE = You do not have a pet to summon
Steps to reproduce
Version & Environment
Client Version: 1.12.1.5875
Commit Hash: https://github.com/vmangos/core/commit/b06ed1f094710cb57d789bf4c51ebb47229ad450
OS Client: Microsoft Windows 11 Pro N 10.0.22000 Build 22000 OS Server: Microsoft Windows 11 Pro N 10.0.22000 Build 22000
Crashlog